Issue 206163003: Issue 17586. Remove unnecessary Source reset from DartEditor.dispose().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 206163003: Issue 17586. Remove unnecessary Source reset from DartEditor.dispose(). (Closed)

Created:
6 years, 9 months ago by scheglov

Modified:
6 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 17586. Remove unnecessary Source reset from DartEditor.dispose(). It is already done in DartReconcilingStrategy.dispose() now. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=17586 Committed: https://code.google.com/p/dart/source/detail?r=34194

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -12 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 9 months ago (2014-03-20 18:53:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34194 (presubmit successful).