Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 2061623002: Introduce JIT code events dispatcher for the isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: rebaseline Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/v8.gyp ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index 7740a1d9bf25572140bc33170e58e92472faced7..59fb36a79c213a4f8068bdb88538ef549f183eac 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -168,13 +168,16 @@ TEST(CodeEvents) {
// Enqueue code creation events.
const char* aaa_str = "aaa";
i::Handle<i::String> aaa_name = factory->NewStringFromAsciiChecked(aaa_str);
- profiler.CodeCreateEvent(i::Logger::FUNCTION_TAG, aaa_code, *aaa_name);
- profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, comment_code, "comment");
- profiler.CodeCreateEvent(i::Logger::STUB_TAG, args5_code, 5);
- profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, comment2_code, "comment2");
+ profiler.CodeCreateEvent(i::CodeEventListener::FUNCTION_TAG, aaa_code,
+ *aaa_name);
+ profiler.CodeCreateEvent(i::CodeEventListener::BUILTIN_TAG, comment_code,
+ "comment");
+ profiler.CodeCreateEvent(i::CodeEventListener::STUB_TAG, args5_code, 5);
+ profiler.CodeCreateEvent(i::CodeEventListener::BUILTIN_TAG, comment2_code,
+ "comment2");
profiler.CodeMoveEvent(comment2_code, moved_code->address());
- profiler.CodeCreateEvent(i::Logger::STUB_TAG, args3_code, 3);
- profiler.CodeCreateEvent(i::Logger::STUB_TAG, args4_code, 4);
+ profiler.CodeCreateEvent(i::CodeEventListener::STUB_TAG, args3_code, 3);
+ profiler.CodeCreateEvent(i::CodeEventListener::STUB_TAG, args4_code, 4);
// Enqueue a tick event to enable code events processing.
EnqueueTickSampleEvent(processor.get(), aaa_code->address());
@@ -224,9 +227,11 @@ TEST(TickEvents) {
processor->Start();
CpuProfiler profiler(isolate, profiles, &generator, processor.get());
- profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, frame1_code, "bbb");
- profiler.CodeCreateEvent(i::Logger::STUB_TAG, frame2_code, 5);
- profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, frame3_code, "ddd");
+ profiler.CodeCreateEvent(i::CodeEventListener::BUILTIN_TAG, frame1_code,
+ "bbb");
+ profiler.CodeCreateEvent(i::CodeEventListener::STUB_TAG, frame2_code, 5);
+ profiler.CodeCreateEvent(i::CodeEventListener::BUILTIN_TAG, frame3_code,
+ "ddd");
EnqueueTickSampleEvent(processor.get(), frame1_code->instruction_start());
EnqueueTickSampleEvent(
@@ -291,7 +296,7 @@ TEST(Issue1398) {
processor->Start();
CpuProfiler profiler(isolate, profiles, &generator, processor.get());
- profiler.CodeCreateEvent(i::Logger::BUILTIN_TAG, code, "bbb");
+ profiler.CodeCreateEvent(i::CodeEventListener::BUILTIN_TAG, code, "bbb");
i::TickSample* sample = processor->StartTickSample();
sample->pc = code->address();
@@ -1033,8 +1038,8 @@ static void TickLines(bool optimize) {
i::Handle<i::String> str = factory->NewStringFromAsciiChecked(func_name);
int line = 1;
int column = 1;
- profiler.CodeCreateEvent(i::Logger::FUNCTION_TAG, code, func->shared(), *str,
- line, column);
+ profiler.CodeCreateEvent(i::CodeEventListener::FUNCTION_TAG, code,
+ func->shared(), *str, line, column);
// Enqueue a tick event to enable code events processing.
EnqueueTickSampleEvent(processor.get(), code_address);
« no previous file with comments | « src/v8.gyp ('k') | test/cctest/test-profile-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698