Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "src/isolate.h" | 5 #include "src/isolate.h" |
| 6 | 6 |
| 7 #include <stdlib.h> | 7 #include <stdlib.h> |
| 8 | 8 |
| 9 #include <fstream> // NOLINT(readability/streams) | 9 #include <fstream> // NOLINT(readability/streams) |
| 10 #include <sstream> | 10 #include <sstream> |
| (...skipping 1851 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 1862 // TODO(bmeurer) Initialized lazily because it depends on flags; can | 1862 // TODO(bmeurer) Initialized lazily because it depends on flags; can |
| 1863 // be fixed once the default isolate cleanup is done. | 1863 // be fixed once the default isolate cleanup is done. |
| 1864 random_number_generator_(NULL), | 1864 random_number_generator_(NULL), |
| 1865 rail_mode_(PERFORMANCE_DEFAULT), | 1865 rail_mode_(PERFORMANCE_DEFAULT), |
| 1866 serializer_enabled_(enable_serializer), | 1866 serializer_enabled_(enable_serializer), |
| 1867 has_fatal_error_(false), | 1867 has_fatal_error_(false), |
| 1868 initialized_from_snapshot_(false), | 1868 initialized_from_snapshot_(false), |
| 1869 is_tail_call_elimination_enabled_(true), | 1869 is_tail_call_elimination_enabled_(true), |
| 1870 cpu_profiler_(NULL), | 1870 cpu_profiler_(NULL), |
| 1871 heap_profiler_(NULL), | 1871 heap_profiler_(NULL), |
| 1872 code_event_dispatcher_(new CodeEventDispatcher()), | |
| 1872 function_entry_hook_(NULL), | 1873 function_entry_hook_(NULL), |
| 1873 deferred_handles_head_(NULL), | 1874 deferred_handles_head_(NULL), |
| 1874 optimizing_compile_dispatcher_(NULL), | 1875 optimizing_compile_dispatcher_(NULL), |
| 1875 stress_deopt_count_(0), | 1876 stress_deopt_count_(0), |
| 1876 virtual_handler_register_(NULL), | 1877 virtual_handler_register_(NULL), |
| 1877 virtual_slot_register_(NULL), | 1878 virtual_slot_register_(NULL), |
| 1878 next_optimization_id_(0), | 1879 next_optimization_id_(0), |
| 1879 js_calls_from_api_counter_(0), | 1880 js_calls_from_api_counter_(0), |
| 1880 #if TRACE_MAPS | 1881 #if TRACE_MAPS |
| 1881 next_unique_sfi_id_(0), | 1882 next_unique_sfi_id_(0), |
| (...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 2019 logger_->TearDown(); | 2020 logger_->TearDown(); |
| 2020 | 2021 |
| 2021 delete interpreter_; | 2022 delete interpreter_; |
| 2022 interpreter_ = NULL; | 2023 interpreter_ = NULL; |
| 2023 | 2024 |
| 2024 cancelable_task_manager()->CancelAndWait(); | 2025 cancelable_task_manager()->CancelAndWait(); |
| 2025 | 2026 |
| 2026 delete cpu_profiler_; | 2027 delete cpu_profiler_; |
| 2027 cpu_profiler_ = NULL; | 2028 cpu_profiler_ = NULL; |
| 2028 | 2029 |
| 2030 code_event_dispatcher_.reset(); | |
|
Yang
2016/06/14 13:38:12
Is there an advantage for using unique_ptr over us
alph
2016/06/14 16:38:20
It better depicts ownership semantics used here, a
| |
| 2031 | |
| 2029 delete root_index_map_; | 2032 delete root_index_map_; |
| 2030 root_index_map_ = NULL; | 2033 root_index_map_ = NULL; |
| 2031 | 2034 |
| 2032 ClearSerializerData(); | 2035 ClearSerializerData(); |
| 2033 } | 2036 } |
| 2034 | 2037 |
| 2035 | 2038 |
| 2036 void Isolate::SetIsolateThreadLocals(Isolate* isolate, | 2039 void Isolate::SetIsolateThreadLocals(Isolate* isolate, |
| 2037 PerIsolateThreadData* data) { | 2040 PerIsolateThreadData* data) { |
| 2038 base::Thread::SetThreadLocal(isolate_key_, isolate); | 2041 base::Thread::SetThreadLocal(isolate_key_, isolate); |
| (...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3054 // Then check whether this scope intercepts. | 3057 // Then check whether this scope intercepts. |
| 3055 if ((flag & intercept_mask_)) { | 3058 if ((flag & intercept_mask_)) { |
| 3056 intercepted_flags_ |= flag; | 3059 intercepted_flags_ |= flag; |
| 3057 return true; | 3060 return true; |
| 3058 } | 3061 } |
| 3059 return false; | 3062 return false; |
| 3060 } | 3063 } |
| 3061 | 3064 |
| 3062 } // namespace internal | 3065 } // namespace internal |
| 3063 } // namespace v8 | 3066 } // namespace v8 |
| OLD | NEW |