Introduce JIT code events dispatcher for the isolate.

Introduce JIT code events dispatcher for the isolate.

The patch introduces a dedicated dispatching class for JIT code events. It is
set as a helper on the isolate.
This allows classes across v8 to break their dependency on Logger and CpuProfiler.
These two became just regular clients of the dispatcher.

BUG=v8:4789
Committed: https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c
Cr-Commit-Position: refs/heads/master@{#37005}

[alph, 2016-06-13 09:31:10]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 09:31:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061623002/1

[commit-bot: I haz the power, 2016-06-13 09:59:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 09:59:50]

Dry run: This issue passed the CQ dry run.

[alph, 2016-06-13 10:00:56]

alph@chromium.org changed reviewers:
+ bmeurer@chromium.org, jochen@chromium.org, yangguo@chromium.org

[alph, 2016-06-13 10:00:56]

Benedikt, could you please take a look.

Yang, could you please look at:
  src/regexp
  src/snapshot

Jochen, could you please RS src/heap

Thanks

[Benedikt Meurer, 2016-06-13 12:14:03]

I don't have a lot of background on this. Yang volunteered to do the main
review.

[Yang, 2016-06-14 13:38:12]

lgtm

https://codereview.chromium.org/2061623002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2061623002/diff/1/src/isolate.cc#newcode2030
src/isolate.cc:2030: code_event_dispatcher_.reset();
Is there an advantage for using unique_ptr over using a raw pointer that we have
to delete here?

https://codereview.chromium.org/2061623002/diff/1/src/log-inl.h
File src/log-inl.h (right):

https://codereview.chromium.org/2061623002/diff/1/src/log-inl.h#newcode22
src/log-inl.h:22: switch (tag) {
why don't we simplify this to

if (script->type() == Script::TYPE_NATIVE) {
  switch (tag) {
    ...
  }
}

[alph, 2016-06-14 16:38:20]

Thanks for review!

@bmeurer: Could you please still do owners review of:
  src/compiler
  src/ic
  src/interpreter

@jochen: Could you please RS:
  src/heap

https://codereview.chromium.org/2061623002/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/2061623002/diff/1/src/isolate.cc#newcode2030
src/isolate.cc:2030: code_event_dispatcher_.reset();
On 2016/06/14 13:38:12, Yang wrote:
> Is there an advantage for using unique_ptr over using a raw pointer that we
have
> to delete here?

It better depicts ownership semantics used here, and is more leakproof.

https://codereview.chromium.org/2061623002/diff/1/src/log-inl.h
File src/log-inl.h (right):

https://codereview.chromium.org/2061623002/diff/1/src/log-inl.h#newcode22
src/log-inl.h:22: switch (tag) {
On 2016/06/14 13:38:12, Yang wrote:
> why don't we simplify this to
> 
> if (script->type() == Script::TYPE_NATIVE) {
>   switch (tag) {
>     ...
>   }
> }

Done.

[alph, 2016-06-14 17:28:21]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 17:28:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061623002/20001

[commit-bot: I haz the power, 2016-06-14 17:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 17:29:36]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7316)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7305)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3218)

[alph, 2016-06-14 19:05:22]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 19:05:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061623002/40001

[commit-bot: I haz the power, 2016-06-14 19:36:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:36:19]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2016-06-15 13:03:46]

LGTM.

[ulan, 2016-06-15 13:20:04]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-06-15 13:20:04]

heap lgtm

[alph, 2016-06-15 13:20:35]

The CQ bit was checked by alph@chromium.org

[alph, 2016-06-15 13:20:35]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2061623002/#ps40001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-06-15 13:20:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061623002/40001

[commit-bot: I haz the power, 2016-06-15 13:22:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-15 13:24:32]

Description was changed from

==========
Introduce JIT code events dispatcher for the isolate.

The patch introduces a dedicated dispatching class for JIT code events. It is
set as a helper on the isolate.
This allows classes across v8 to break their dependency on Logger and
CpuProfiler.
These two became just regular clients of the dispatcher.

BUG=v8:4789
==========

to

==========
Introduce JIT code events dispatcher for the isolate.

The patch introduces a dedicated dispatching class for JIT code events. It is
set as a helper on the isolate.
This allows classes across v8 to break their dependency on Logger and
CpuProfiler.
These two became just regular clients of the dispatcher.

BUG=v8:4789

Committed: https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c
Cr-Commit-Position: refs/heads/master@{#37005}
==========

[commit-bot: I haz the power, 2016-06-15 13:24:34]

Patchset 3 (id:??) landed as
https://crrev.com/9df23510eaa12eb5c298cf68a92e90c6e992855c
Cr-Commit-Position: refs/heads/master@{#37005}