Fix crash when switching to a profile that cannot be opened

chrome/browser/ui/profile_error_dialog.h

Index: chrome/browser/ui/profile_error_dialog.h
diff --git a/chrome/browser/ui/profile_error_dialog.h b/chrome/browser/ui/profile_error_dialog.h
index eec7ba97c96df6c802ab2e0e2218172992b32856..0f0b0208ee84a0fd0262b4a0961a79f375f3ac71 100644
--- a/chrome/browser/ui/profile_error_dialog.h
+++ b/chrome/browser/ui/profile_error_dialog.h
@@ -18,6 +18,7 @@ enum ProfileErrorType {
   PROFILE_ERROR_DB_TOKEN_WEB_DATA,
   PROFILE_ERROR_DB_WEB_DATA,
   PROFILE_ERROR_DB_KEYWORD_WEB_DATA,
+  PROFILE_ERROR_SWITCH_TO_FAILURE,

[Peter Kasting, 2016/06/16 07:02:11]

Nit: This sounds like "we switched to failure" rather than "failure to switch to
this profile."

Consider changing this enum to an enum class named ProfileError so you can
remove PROFILE_ERROR_ from in front of every value, then naming these more
descriptively.  For example, is HISTORY for errors opening the history DB, or
does it cover more than that? A name like COULDNT_OPEN_HISTORY_DB would be way
better than HISTORY, just as something like
TRIED_TO_SWITCH_TO_UNOPENABLE_PROFILE would be better than SWITCH_TO_FAILURE.

[WC Leung, 2016/06/16 10:04:10]

Good point. I'll make my enum more descriptive.

BTW, adding a class makes the enum shorter, but does not make the code in the
callsites shorter (the class name is just prefixed).

[Peter Kasting, 2016/06/16 11:00:00]

I know.

[WC Leung, 2016/06/20 16:54:08]

Created issue 621555 to track this task.

   PROFILE_ERROR_END
 };