Fix crash when switching to a profile that cannot be opened

chrome/browser/profiles/profile_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_window.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/account_reconcilor_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_ui_util.h"
 #include "chrome/browser/sync/profile_sync_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/profile_chooser_constants.h"
+#include "chrome/browser/ui/profile_error_dialog.h"
 #include "chrome/browser/ui/user_manager.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
+#include "chrome/grit/generated_resources.h"
 #include "components/browser_sync/browser/profile_sync_service.h"
 #include "components/flags_ui/pref_service_flags_storage.h"
 #include "components/prefs/pref_service.h"
 #include "components/signin/core/browser/account_reconcilor.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "components/signin/core/common/profile_management_switches.h"
 #include "components/signin/core/common/signin_pref_names.h"
 #include "components/signin/core/common/signin_switches.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 159 matching lines @@
 }
 
 void OpenBrowserWindowForProfile(
     ProfileManager::CreateCallback callback,
     bool always_create,
     bool is_new_profile,
     Profile* profile,
     Profile::CreateStatus status) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
+  if (status == Profile::CREATE_STATUS_LOCAL_FAIL) {
+    ShowProfileErrorDialog(PROFILE_ERROR_SWITCH_TO_FAILURE,
+                           IDS_COULDNT_SWITCH_PROFILE_ERROR);
+    return;

[Peter Kasting, 2016/06/13 04:43:20]

Nit: Not necessary (next conditional does this for us)

[WC Leung, 2016/06/13 08:06:45]

Acknowledged.

+  }
+
   if (status != Profile::CREATE_STATUS_INITIALIZED)
     return;
 
   chrome::startup::IsProcessStartup is_process_startup =
       chrome::startup::IS_NOT_PROCESS_STARTUP;
   chrome::startup::IsFirstRun is_first_run = chrome::startup::IS_NOT_FIRST_RUN;
 
   // If this is a brand new profile, then start a first run window.
   if (is_new_profile) {
     is_process_startup = chrome::startup::IS_PROCESS_STARTUP;
@@ skipping 265 matching lines @@
   PrefService* local_state = g_browser_process->local_state();
   const bool dismissed = local_state->GetBoolean(
       prefs::kProfileAvatarRightClickTutorialDismissed);
 
   // Don't show the tutorial if it's already been dismissed or if right-clicking
   // wouldn't show any targets.
   return !dismissed && HasProfileSwitchTargets(profile);
 }
 
 }  // namespace profiles