Fix crash when switching to a profile that cannot be opened

chrome/browser/profiles/profile_manager_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
+#include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/password_manager/password_store_factory.h"
 #include "chrome/browser/profiles/profile_attributes_entry.h"
 #include "chrome/browser/profiles/profile_attributes_storage.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_window.h"
@@ skipping 12 matching lines @@
 
 #if defined(OS_CHROMEOS)
 #include "base/path_service.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chromeos/chromeos_switches.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #endif
 
+#if defined(OS_WIN)
+#include <windows.h>
+#include "base/test/test_file_util.h"
+#endif
+
 namespace {
 
 const ProfileManager::CreateCallback kOnProfileSwitchDoNothing;
 
 // An observer that returns back to test code after a new profile is
 // initialized.
 void OnUnblockOnProfileCreation(base::RunLoop* run_loop,
                                 Profile* profile,
                                 Profile::CreateStatus status) {
   if (status == Profile::CREATE_STATUS_INITIALIZED)
@@ skipping 92 matching lines @@
 
 // TODO(jeremy): crbug.com/103355 - These tests should be enabled on all
 // platforms.
 class ProfileManagerBrowserTest : public InProcessBrowserTest {
  protected:
   void SetUpCommandLine(base::CommandLine* command_line) override {
 #if defined(OS_CHROMEOS)
     command_line->AppendSwitch(
         chromeos::switches::kIgnoreUserProfileMappingForTests);
 #endif
+    command_line->AppendSwitch(switches::kNoErrorDialogs);
   }
 };
 
 #if defined(OS_MACOSX)
 
 // Delete single profile and make sure a new one is created.
 IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, DeleteSingletonProfile) {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ProfileAttributesStorage& storage =
       profile_manager->GetProfileAttributesStorage();
@@ skipping 129 matching lines @@
   EXPECT_EQ(chrome::GetTotalBrowserCount(), 2U);
 
   // Now close all browser windows.
   std::vector<Profile*> profiles = profile_manager->GetLoadedProfiles();
   for (std::vector<Profile*>::const_iterator it = profiles.begin();
        it != profiles.end(); ++it) {
     BrowserList::CloseAllBrowsersWithProfile(*it);
   }
 }
 
-IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest,
-                       SwitchToProfile) {
+IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, SwitchToProfile) {
   // If multiprofile mode is not enabled, you can't switch between profiles.
   if (!profiles::IsMultipleProfilesEnabled())
     return;
 
   ProfileManager* profile_manager = g_browser_process->profile_manager();
   ProfileAttributesStorage& storage =
       profile_manager->GetProfileAttributesStorage();
   size_t initial_profile_count = profile_manager->GetNumberOfProfiles();
   base::FilePath path_profile1 = GetFirstNonSigninProfile(storage);
 
@@ skipping 33 matching lines @@
   // Switch to the first profile without opening a new window.
   profiles::SwitchToProfile(path_profile1, false, kOnProfileSwitchDoNothing,
                             ProfileMetrics::SWITCH_PROFILE_ICON);
   EXPECT_EQ(2U, chrome::GetTotalBrowserCount());
   EXPECT_EQ(2U, browser_list->size());
 
   EXPECT_EQ(path_profile1, browser_list->get(0)->profile()->GetPath());
   EXPECT_EQ(path_profile2, browser_list->get(1)->profile()->GetPath());
 }
 
+#if defined(OS_WIN)

[Peter Kasting, 2016/06/13 04:43:20]

It would be nice to be able to run this test on all platforms.  Is it possible
to implement DenyFilePermission() on non-Win?

[WC Leung, 2016/06/13 08:06:45]

Sadly I don't think that is possible. I've done a web search, and found no
equivalent of FILE_ADD_SUBDIRECTORY permission in linux. I don't think there's
an equivalent in Mac too, because the "rwx" system is also used.

The good news is : the bug appears to be Windows only. (Peter, can you confirm
this for me?)

[WC Leung, 2016/06/15 13:08:39]

I mean confirm with the crash logs (I don't have access to things internal to
Google.)

+IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, SwitchToProfileFails) {
+  base::FilePath user_data_dir =
+      g_browser_process->profile_manager()->user_data_dir();
+  base::DenyFilePermission(user_data_dir, FILE_ADD_SUBDIRECTORY);
+  // Switch to a profile that cannot be loaded or created. This must fail
+  // gracefully with no crash.
+  profiles::SwitchToProfile(user_data_dir.AppendASCII("Profile 1"),
+                            false,
+                            kOnProfileSwitchDoNothing,
+                            ProfileMetrics::SWITCH_PROFILE_ICON);
+}
+#endif  // defined(OS_WIN)
+
 // Flakes on Windows: http://crbug.com/314905
 #if defined(OS_WIN)
 #define MAYBE_EphemeralProfile DISABLED_EphemeralProfile
 #else
 #define MAYBE_EphemeralProfile EphemeralProfile
 #endif
 IN_PROC_BROWSER_TEST_F(ProfileManagerBrowserTest, MAYBE_EphemeralProfile) {
   // If multiprofile mode is not enabled, you can't switch between profiles.
   if (!profiles::IsMultipleProfilesEnabled())
     return;
@@ skipping 127 matching lines @@
 
   EXPECT_FALSE(profile->HasOffTheRecordProfile());
   EXPECT_FALSE(profile_manager->IsValidProfile(incognito_profile));
   EXPECT_EQ(initial_profile_count, profile_manager->GetNumberOfProfiles());
   // After destroying the incognito profile incognito preferences should be
   // cleared so the default save path should be taken from the main profile.
   EXPECT_FALSE(profile->GetOffTheRecordPrefs()
                    ->GetFilePath(prefs::kSaveFileDefaultDirectory)
                    .empty());
 }