Fix crash when switching to a profile that cannot be opened

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <stdint.h>
 
 #include <set>
 #include <string>
@@ skipping 1086 matching lines @@
   if (success && !go_off_the_record)
     RunCallbacks(callbacks, profile, Profile::CREATE_STATUS_CREATED);
 
   // Perform initialization.
   if (success) {
     DoFinalInit(profile, go_off_the_record);
     if (go_off_the_record)
       profile = profile->GetOffTheRecordProfile();
     info->created = true;
   } else {
-    profile = NULL;
+    profile = nullptr;
+    failed_profiles_.emplace_back(std::move(iter->second->profile));

[Peter Kasting, 2016/06/13 04:43:20]

Nit: There's no real reason here to use emplace_back() over push_back().

[WC Leung, 2016/06/13 08:06:45]

Acknowledged.

[WC Leung, 2016/06/15 13:08:39]

Done.

     profiles_info_.erase(iter);
     // TODO(yiyaoliu): This is temporary, remove it after it's not used.
     UMA_HISTOGRAM_COUNTS_100("UMA.ProfilesCount.AfterErase",
                              profiles_info_.size());
   }
 
   if (profile) {
     // If this was the guest or system profile, finish setting its special
     // status.
     if (profile->IsGuestSession() || profile->IsSystemProfile())
@@ skipping 398 matching lines @@
 }
 
 ProfileManager::ProfileInfo::ProfileInfo(
     Profile* profile,
     bool created)
     : profile(profile),
       created(created) {
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
-  ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
+  if (profile)
+    ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }
 
 #if !defined(OS_ANDROID)
 void ProfileManager::UpdateLastUser(Profile* last_active) {
   PrefService* local_state = g_browser_process->local_state();
   DCHECK(local_state);
   // Only keep track of profiles that we are managing; tests may create others.
   // Also never consider the SystemProfile as "active".
   if (profiles_info_.find(last_active->GetPath()) != profiles_info_.end() &&
       !last_active->IsSystemProfile()) {
@@ skipping 102 matching lines @@
 
   FinishDeletingProfile(profile_to_delete_path, new_active_profile_path);
   if (!original_callback.is_null())
     original_callback.Run(loaded_profile, status);
 }
 #endif  // !defined(OS_ANDROID)
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }