Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2061573002: Use contents of python deps to get md5 stamp instead of paths only (Closed)

Created:
4 years, 6 months ago by mlopatkin
Modified:
4 years, 6 months ago
Reviewers:
agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use contents of python deps to get md5 stamp instead of paths only While contents of python dependencies doesn't affect contents of a depfile it definitely affects the output: typical usage of CallAndWriteDepfileIfStale only regenerates script's output if md5 sum changes, in a helper function. If content of the python file (like lint.py) isn't used to generate md5 then it leads to weird results: do a full build, change lint.py to always throw exception in _OnStaleMd5, re-run build, but nothing happens, _OnStaleMd5 isn't called. BUG=619329 Committed: https://crrev.com/3218d50d461833795d64c71f8b4c0517e58a8b50 Cr-Commit-Position: refs/heads/master@{#400012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
mlopatkin
4 years, 6 months ago (2016-06-11 19:07:34 UTC) #3
agrieve
On 2016/06/11 19:07:34, mlopatkin wrote: lgtm
4 years, 6 months ago (2016-06-15 17:27:13 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061573002/1
4 years, 6 months ago (2016-06-15 20:14:39 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 21:11:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061573002/1
4 years, 6 months ago (2016-06-15 21:17:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 21:22:10 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 21:23:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3218d50d461833795d64c71f8b4c0517e58a8b50
Cr-Commit-Position: refs/heads/master@{#400012}

Powered by Google App Engine
This is Rietveld 408576698