Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 206153004: ninja: Reduce size of individual_generated_bindings by another 45kB / 15%. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: Reduce size of individual_generated_bindings by another 45kB / 15%. 1. Only write unique_name for rules on Windows, it's unused elsewhere. Makes individual_generated_bindings.ninja another 30kB / 10% smaller. 2. Don't include the hash in the rule name: It's not needed since the stamp file has a qualified path. Saves another 14kB. BUG=350317 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1880

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pylib/gyp/generator/ninja.py View 1 2 chunks +6 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Nico
Makes generated ninja files a tiny bit tinier on non-win
6 years, 9 months ago (2014-03-20 18:08:07 UTC) #1
scottmg
lgtm
6 years, 9 months ago (2014-03-20 19:16:59 UTC) #2
Nico
(I uploaded a 2nd patch set that does slightly more (4 lines instead of 2) ...
6 years, 9 months ago (2014-03-20 19:18:33 UTC) #3
Nico
Committed patchset #2 manually as r1880 (presubmit successful).
6 years, 9 months ago (2014-03-20 19:21:57 UTC) #4
scottmg
6 years, 9 months ago (2014-03-20 19:29:50 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/206153004/diff/20001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/206153004/diff/20001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:670: rule['rule_name'], inputs,
order_only=prebuild)]
This tends to have spaces, maybe that'll break something? If it works though,
still LGTM.

Powered by Google App Engine
This is Rietveld 408576698