chrome/browser/ui/views/translate/translate_bubble_view.h - Issue 2061523002: Enable the translate bubble to be dismissed when user ignores it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 2061523002: Enable the translate bubble to be dismissed when user ignores it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc ('K') | « chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/translate/translate_bubble_view.h

diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h

index 6aa224d00c6a7a417fa88b05789d91b507330f7c..94b2a991ea91c9b6706f1829ac04ce3150070229 100644

--- a/chrome/browser/ui/views/translate/translate_bubble_view.h

+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h

@@ -82,6 +82,9 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,

TranslateBubbleModel* model() { return model_.get(); }

+ // LocationBarBubbleDelegateView:

+ void CloseBubble() override;

Peter Kasting 2016/06/13 20:27:24 This was protected in the base class. Does it nee

hcarmona 2016/06/13 20:49:03 Done, it's now protected.

// views::BubbleDialogDelegateView methods.

void Init() override;

void ButtonPressed(views::Button* sender, const ui::Event& event) override;

@@ -248,6 +251,8 @@ class TranslateBubbleView : public LocationBarBubbleDelegateView,

// Whether the window is an incognito window.

const bool is_in_incognito_window_;

+ std::unique_ptr<WebContentMouseHandler> mouse_handler_;

DISALLOW_COPY_AND_ASSIGN(TranslateBubbleView);

};