Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2061503002: Move the routing-info inside the jingle element. (Closed)

Created:
4 years, 6 months ago by kelvinp
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Move the routing-info inside the jingle element. Previously, routing info are encoded in the iq node. When the host is offline, the talk network responds with an error IQ that doesn't get relayed to the client because it doesn't have the routing info that the signaling service needs. Since an error IQ always contain the original request, by moving the routing info inside the original jingle request, we can reliably route the error message back to the client. Review-Url: https://codereview.chromium.org/2042513002 Cr-Commit-Position: refs/heads/master@{#398383} (cherry picked from commit 046534d38813b82d7f3bcb61b7f8c2fdc7f9cc74) BUG=618143 Committed: https://chromium.googlesource.com/chromium/src/+/cbc9d492a9b1369b4db5715612c7c9170ac20fbe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -30 lines) Patch
M remoting/protocol/jingle_messages.cc View 4 chunks +49 lines, -16 lines 0 comments Download
M remoting/protocol/jingle_messages_unittest.cc View 4 chunks +18 lines, -14 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kelvinp
4 years, 6 months ago (2016-06-11 00:20:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cbc9d492a9b1369b4db5715612c7c9170ac20fbe.

Powered by Google App Engine
This is Rietveld 408576698