Adds support for attaching a market referrer.

Adds support for attaching a market referrer.

Given an intent:// URL, if the application cannot be found and we
redirect the user to Play Market, set the referrer string in the market
URL to the value of market_referrer extra specified in the original
intent.

BUG=603999
Committed: https://crrev.com/439f0a8bc8a1a597e8cf5fbe2595760017cd366f
Cr-Commit-Position: refs/heads/master@{#399637}

[Maria, 2016-06-13 21:06:03]

mariakhomenko@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2016-06-13 23:27:22]

lgtm

https://codereview.chromium.org/2061493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2061493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:318:
.appendQueryParameter("referrer", Uri.decode(marketReferrer))
do we need to do any more sanity checking on the referrer we get?  I guess we
don't really care too much what people pass us.

And it doesn't look like Uri.decode will return null unless passed null.  I
guess android might get sad if we get passed a giant value that is too large for
intents, but that seems to be quite the stretch.

[Maria, 2016-06-13 23:46:26]

https://codereview.chromium.org/2061493002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java
(right):

https://codereview.chromium.org/2061493002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java:318:
.appendQueryParameter("referrer", Uri.decode(marketReferrer))
On 2016/06/13 23:27:21, Ted C wrote:
> do we need to do any more sanity checking on the referrer we get?  I guess we
> don't really care too much what people pass us.
> 
> And it doesn't look like Uri.decode will return null unless passed null.  I
> guess android might get sad if we get passed a giant value that is too large
for
> intents, but that seems to be quite the stretch.

Yeah, I was thinking about this too. I figured the only thing I care about is
that it's properly encoded as a URL (e.g. no spaces), which will happen now
because Uri class auto-encodes stuff.

I suppose it could be too big, but it does seem like a stretch and won't do much
good to the person who causes that to happen, other than disincentivizing people
from clicking their links.

[Maria, 2016-06-13 23:47:04]

The CQ bit was checked by mariakhomenko@chromium.org

[commit-bot: I haz the power, 2016-06-13 23:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061493002/1

[commit-bot: I haz the power, 2016-06-14 01:48:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-14 03:39:58]

Description was changed from

==========
Adds support for attaching a market referrer.

Given an intent:// URL, if the application cannot be found and we
redirect the user to Play Market, set the referrer string in the market
URL to the value of market_referrer extra specified in the original
intent.

BUG=603999
==========

to

==========
Adds support for attaching a market referrer.

Given an intent:// URL, if the application cannot be found and we
redirect the user to Play Market, set the referrer string in the market
URL to the value of market_referrer extra specified in the original
intent.

BUG=603999

Committed: https://crrev.com/439f0a8bc8a1a597e8cf5fbe2595760017cd366f
Cr-Commit-Position: refs/heads/master@{#399637}
==========

[commit-bot: I haz the power, 2016-06-14 03:39:59]

Patchset 1 (id:??) landed as
https://crrev.com/439f0a8bc8a1a597e8cf5fbe2595760017cd366f
Cr-Commit-Position: refs/heads/master@{#399637}