Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2061443002: PPC: Remove more dead code now that legacy const is gone (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Remove more dead code now that legacy const is gone Port 757221e574ecba543a65f4822c083aa860e030eb Original commit message: Neither globals nor lookup slots can be hole-initialized anymore, thus removing some dead code from the code generators and runtime-scopes. R=adamk@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/817dcf2819d50f9ab44876f0080095c445ac7bba Cr-Commit-Position: refs/heads/master@{#36899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-10 17:24:10 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-10 17:26:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061443002/1
4 years, 6 months ago (2016-06-10 17:26:48 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 17:52:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:54:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/817dcf2819d50f9ab44876f0080095c445ac7bba
Cr-Commit-Position: refs/heads/master@{#36899}

Powered by Google App Engine
This is Rietveld 408576698