Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 206143003: [WebSocket] Delete WebSocketHandle deprecated function. (Closed)

Created:
6 years, 9 months ago by yhirano
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[WebSocket] Delete WebSocketHandle deprecated function. Delete WebSocketHandle::connect(..., const WebString&, ...), which is replaced by WebSocketHandle::connect(..., const WebSerializedOrigin&, ...). BUG=339373 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169902

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M public/platform/WebSocketHandle.h View 1 2 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yhirano
This is a followup of http://src.chromium.org/viewvc/blink?view=revision&revision=169591 and https://src.chromium.org/viewvc/chrome?revision=258358&view=revision
6 years, 9 months ago (2014-03-24 01:33:36 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-24 15:59:11 UTC) #2
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 9 months ago (2014-03-25 01:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/206143003/40001
6 years, 9 months ago (2014-03-25 01:32:43 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 02:36:43 UTC) #5
Message was sent while issue was closed.
Change committed as 169902

Powered by Google App Engine
This is Rietveld 408576698