Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: lib/src/compiler/side_effect_analysis.dart

Issue 2061373003: implement user-defined nSM, Object members on functions (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/compiler/side_effect_analysis.dart
diff --git a/lib/src/compiler/side_effect_analysis.dart b/lib/src/compiler/side_effect_analysis.dart
index b1f9e4a4df5bfc2f37f759b4fb0226e8154735a0..d55c3fb0b7fb1ebfc2ceb0b0baf494df60c42d60 100644
--- a/lib/src/compiler/side_effect_analysis.dart
+++ b/lib/src/compiler/side_effect_analysis.dart
@@ -107,11 +107,12 @@ class _AssignmentFinder extends RecursiveAstVisitor {
class ConstFieldVisitor {
final ConstantVisitor _constantVisitor;
- ConstFieldVisitor(TypeProvider types, Source source)
+ ConstFieldVisitor(TypeProvider types, {Source dummySource})
// TODO(jmesserly): support -D variables on the command line
: _constantVisitor = new ConstantVisitor(
new ConstantEvaluationEngine(types, new DeclaredVariables()),
- new ErrorReporter(AnalysisErrorListener.NULL_LISTENER, source));
+ new ErrorReporter(
+ AnalysisErrorListener.NULL_LISTENER, dummySource));
// TODO(jmesserly): this is used to determine if the field initialization is
// side effect free. We should make the check more general, as things like

Powered by Google App Engine
This is Rietveld 408576698