chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm - Issue 2061353002: [Mac][Material Design] Fix regression with initial bookmark bar text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

Issue 2061353002: [Mac][Material Design] Fix regression with initial bookmark bar text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make -[BookmarkBarToolbarView isOpaque:] return YES Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

index e622db0e18f9e7a565f9e31bf65cce0a6df1b430..02fe283b63f7a5c2f896a4910e5478a7fd69a79f 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_toolbar_view.mm

@@ -24,7 +24,9 @@

@implementation BookmarkBarToolbarView

- (BOOL)isOpaque {

- return [controller_ isInState:BookmarkBar::DETACHED];

+ // -drawRect: calls -drawAsDetachedBubble: or -drawBackground:, both of which

+ // fill the dirty rect with an opaque color.

+ return YES;

}

- (void)resetCursorRects {

« no previous file with comments | « no previous file | no next file » | no next file with comments »