[Mac][Material Design] Fix regression with initial bookmark bar text.

chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h"
 
 #include "chrome/browser/profiles/profile.h"
 #import "chrome/browser/themes/theme_properties.h"
 #import "chrome/browser/themes/theme_service.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_button.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_context_menu_cocoa_controller.h"
 #import "chrome/browser/ui/cocoa/bookmarks/bookmark_folder_target.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/themed_window.h"
 #import "chrome/browser/ui/cocoa/view_id_util.h"
 #include "components/bookmarks/browser/bookmark_pasteboard_helper_mac.h"
 #include "components/bookmarks/browser/bookmark_utils.h"
 #include "content/public/browser/user_metrics.h"
+#include "grit/theme_resources.h"
 #import "third_party/mozilla/NSPasteboard+Utils.h"
 #include "ui/base/clipboard/clipboard_util_mac.h"
+#import "ui/base/cocoa/nsgraphics_context_additions.h"
 #import "ui/base/cocoa/nsview_additions.h"
 
 using base::UserMetricsAction;
 using bookmarks::BookmarkModel;
 using bookmarks::BookmarkNode;
 
+@interface NSView (Private)

[tapted, 2016/06/15 02:09:04]

nit: PrivateAPI? (Chrome has a few "Private" categories just for extending
interfaces of our own classes e.g. BrowserWindowController(Private))

+// Private Appkit API for hinting at the color appearing behind a transparent
+// view (allowing subpixel anti-aliasing to work correctly).
+- (void)setFontSmoothingBackgroundColor:(NSColor*)aColor;
+@end
+
 @interface BookmarkBarView (Private)
 - (void)themeDidChangeNotification:(NSNotification*)aNotification;
 - (void)updateTheme:(const ui::ThemeProvider*)themeProvider;
 
 // NSView override.
 - (void)setFrameSize:(NSSize)size;
 @end
 
 @implementation BookmarkBarView
 
@@ skipping 54 matching lines @@
 }
 
 // Called after a theme change took place, possibly for a different profile.
 - (void)themeDidChangeNotification:(NSNotification*)notification {
   [self updateTheme:[[self window] themeProvider]];
 }
 
 // Adapt appearance to the current theme. Called after theme changes and before
 // this is shown for the first time.
 - (void)updateTheme:(const ui::ThemeProvider*)themeProvider {
+  // Undo any background color set for font smoothing.
+  if ([importBookmarksButton_ respondsToSelector:
+           @selector(setFontSmoothingBackgroundColor)]) {

[tapted, 2016/06/15 02:09:04]

@selector(setFontSmoothingBackgroundColor:)? (missing colon)

+    [importBookmarksButton_ setFontSmoothingBackgroundColor:nil];
+    [importBookmarksButton_ setNeedsDisplay:YES];
+  }
   if (!themeProvider)
     return;
 
   NSColor* color =
       themeProvider->GetNSColor(ThemeProperties::COLOR_BOOKMARK_TEXT);
   [noItemTextfield_ setTextColor:color];
+
+  // When not using a System theme, set the background color for font smoothing
+  // using a private API. The issue is that the |importBookmarksButton_|'s text
+  // is being drawn on a transparent background. Subpixel anti-aliasing needs
+  // to know the background color of the pixels the text is being drawn on top
+  // of - because the textfield is transparent, it can't know the color and so
+  // the anti-aliasing looks weird. This private API allows us to give the
+  // button a hint about the color of the background it will appear over.
+  if (!themeProvider->UsingSystemTheme()) {
+    [importBookmarksButton_ setFontSmoothingBackgroundColor:

[tapted, 2016/06/15 02:09:04]

if (. respondsToSelector..)?

+        themeProvider->GetNSImageColorNamed(IDR_THEME_TOOLBAR)];

[tapted, 2016/06/15 02:09:04]

I have no idea whether fontSmoothingBackgroundColor supports "pattern"
NSColors.. but I suspect it will be out of phase anyway - I don't think we
should do this.

+  }
 }
 
 // Mouse down events on the bookmark bar should not allow dragging the parent
 // window around.
 - (BOOL)mouseDownCanMoveWindow {
   return NO;
 }
 
 - (BookmarkBarTextField*)noItemTextfield {
   return noItemTextfield_;
@@ skipping 172 matching lines @@
 }
 
 @end  // @implementation BookmarkBarView
 
 @implementation BookmarkBarTextField
 
 - (NSMenu*)menu {
   return [barView_ menu];
 }
 
+- (void)drawRect:(NSRect)dirtyRect {
+  const ui::ThemeProvider* themeProvider = [[self window] themeProvider];
+  // To allow subpixel anti-aliasing of the button's title to render correctly,
+  // draw the themed background before drawing the title.
+  if (themeProvider) {
+    bool active =
+        [[self window] isMainWindow] || !themeProvider->UsingSystemTheme();
+    int imageColorName = active ? IDR_THEME_TOOLBAR
+                                : IDR_THEME_TOOLBAR_INACTIVE;
+    [themeProvider->GetNSImageColorNamed(imageColorName) set];
+    NSPoint position = [[self window]
+        themeImagePositionForAlignment:THEME_IMAGE_ALIGN_WITH_TAB_STRIP];
+    [[NSGraphicsContext currentContext] cr_setPatternPhase:position
+                                                   forView:self];
+    NSRectFill(dirtyRect);
+  }
+
+  [super drawRect:dirtyRect];
+}
+
 @end  // @implementation BookmarkBarTextField
 
 @implementation BookmarkBarItemContainer
 
 - (NSMenu*)menu {
   return [barView_ menu];
 }
 
 @end  // @implementation BookmarkBarItemContainer