Issue 206133002: Remove FormatType usage from ClipboardHostMsg_IsFormatAvailable.

Issue 206133002: Remove FormatType usage from ClipboardHostMsg_IsFormatAvailable. (Closed)

Created:
6 years, 9 months ago by dcheng

Modified:
6 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dcheng, tony

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove FormatType usage from ClipboardHostMsg_IsFormatAvailable. Since ClipboardHostMsg_ReadText also depended on this IPC message, the UTF16 to ASCII fallback into ClipboardMessageFilter so this logic doesn't need to be implemented in ClipboardClient. BUG=319285 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258391

Patch Set 1 #

Patch Set 2 : Fix Win/Mac typo #

Total comments: 6

Patch Set 3 : Address comments #

Patch Set 4 : Also rename kClipboardFormatLast #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -64 lines)			Patch
M	content/browser/renderer_host/clipboard_message_filter.h	View	1 2	3 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/clipboard_message_filter.cc	View	1 2	4 chunks	+36 lines, -12 lines	0 comments	Download
A	content/common/clipboard_format.h	View	1 2 3	1 chunk	+20 lines, -0 lines	0 comments	Download
M	content/common/clipboard_messages.h	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	content/content_common.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/clipboard_client.h	View	1 2	3 chunks	+4 lines, -6 lines	0 comments	Download
M	content/renderer/renderer_clipboard_client.h	View		2 chunks	+1 line, -3 lines	0 comments	Download
M	content/renderer/renderer_clipboard_client.cc	View		2 chunks	+2 lines, -9 lines	0 comments	Download
M	content/renderer/webclipboard_impl.cc	View	1 2	3 chunks	+10 lines, -28 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

dcheng

After this and the removal of ClipboardHostMsg_ReadData land, we should be able to remove the ...

6 years, 9 months ago (2014-03-20 07:19:08 UTC) #1

jam

lgtm https://codereview.chromium.org/206133002/diff/2/content/common/clipboard_message_enums.h File content/common/clipboard_message_enums.h (right): https://codereview.chromium.org/206133002/diff/2/content/common/clipboard_message_enums.h#newcode10 content/common/clipboard_message_enums.h:10: enum ClipboardFormat { i would just call this ...

6 years, 9 months ago (2014-03-20 16:07:08 UTC) #2

dcheng

https://codereview.chromium.org/206133002/diff/2/content/common/clipboard_message_enums.h File content/common/clipboard_message_enums.h (right): https://codereview.chromium.org/206133002/diff/2/content/common/clipboard_message_enums.h#newcode10 content/common/clipboard_message_enums.h:10: enum ClipboardFormat { On 2014/03/20 16:07:08, jam wrote: > ...

6 years, 9 months ago (2014-03-20 17:52:06 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/206133002/50001

6 years, 9 months ago (2014-03-20 17:55:28 UTC) #5

Message was sent while issue was closed.

Change committed as 258391

Expand Messages | Collapse Messages