components/precache/core/precache_fetcher.cc - Issue 2061303003: Precache should cancel when there is user traffic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/core/precache_fetcher.cc

Issue 2061303003: Precache should cancel when there is user traffic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor fix Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/precache/core/precache_fetcher.cc

diff --git a/components/precache/core/precache_fetcher.cc b/components/precache/core/precache_fetcher.cc

index 7b567611a4958b6112072dcc822f81d6437f71a6..379774aebbd97e08b5d78faebb007d24cbc0c155 100644

--- a/components/precache/core/precache_fetcher.cc

+++ b/components/precache/core/precache_fetcher.cc

@@ -296,7 +296,7 @@ void PrecacheFetcher::RecordCompletionStatistics(

// If there are resource URLs left to fetch, the last manifest is not yet

// completed.

- if (remaining_resource_urls_to_fetch > 0)

+ if (remaining_resource_urls_to_fetch > 0 && manifests_completed > 0)

Raj 2016/06/14 21:35:16 This additional check fixes a possible DCHECK fail

--manifests_completed;

DCHECK_GE(manifests_completed, 0);

« no previous file with comments | « components/precache/content/precache_manager.cc ('k') | no next file » | no next file with comments »