chrome/browser/precache/precache_util.h - Issue 2061303003: Precache should cancel when there is user traffic

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/precache/precache_util.h

Issue 2061303003: Precache should cancel when there is user traffic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	bengr 2016/07/06 17:04:27 Current convention is to omit the "(c)" Current convention is to omit the "(c)" Raj 2016/07/06 18:28:23 Done. Show quoted text On 2016/07/06 17:04:27, bengr wrote: > Current convention is to omit the "(c)" Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PRECACHE_PRECACHE_UTIL_H_

	6 #define CHROME_BROWSER_PRECACHE_PRECACHE_UTIL_H_

	7

	8 #include "base/time/time.h"
	bengr 2016/07/06 17:04:27 I don't think you need this here. I don't think you need this here. Raj 2016/07/06 18:28:23 Done. Show quoted text On 2016/07/06 17:04:27, bengr wrote: > I don't think you need this here. Done.
	9 #include "net/url_request/url_request.h"
	bengr 2016/07/06 17:04:27 You should be able to forward declare this instead You should be able to forward declare this instead. Raj 2016/07/06 18:28:23 Done. Show quoted text On 2016/07/06 17:04:27, bengr wrote: > You should be able to forward declare this instead. Done.
	10 #include "url/gurl.h"
	bengr 2016/07/06 17:04:27 I don't think you need this here. I don't think you need this here. Raj 2016/07/06 18:28:23 Done. Show quoted text On 2016/07/06 17:04:27, bengr wrote: > I don't think you need this here. Done.
	11

	12 namespace precache {

	13

	14 void UpdatePrecacheMetricsAndState(const net::URLRequest* request,

	15 void* profile_id);

	16

	17 } // namespace precache

	18

	19 #endif // CHROME_BROWSER_PRECACHE_PRECACHE_UTIL_H_

OLD	NEW

« no previous file with comments | « chrome/browser/net/chrome_network_delegate.cc ('k') | chrome/browser/precache/precache_util.cc » ('j') | chrome/browser/precache/precache_util.cc » ('J')