Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2061303002: [Autofill] Log the number of profiles considered/removed during dedupe. (Closed)

Created:
4 years, 6 months ago by Mathieu
Modified:
4 years, 6 months ago
Reviewers:
sebsg, rkaplow
CC:
asvitkine+watch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Log the number of profiles considered/removed during dedupe. BUG=618356 TEST=PersonalDataManagerTest Committed: https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da Cr-Commit-Position: refs/heads/master@{#399991}

Patch Set 1 #

Patch Set 2 : clean #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M components/autofill/core/browser/autofill_metrics.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 6 chunks +22 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mathieu
Hi, PTAL!
4 years, 6 months ago (2016-06-14 21:33:23 UTC) #2
rkaplow
lgtm histogram lg
4 years, 6 months ago (2016-06-14 21:47:53 UTC) #3
sebsg
LGTM thanks!
4 years, 6 months ago (2016-06-15 15:18:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061303002/20001
4 years, 6 months ago (2016-06-15 19:37:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 19:42:11 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 19:42:29 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 19:43:48 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f31a7d478991d03138956eb6665424d53b0039da
Cr-Commit-Position: refs/heads/master@{#399991}

Powered by Google App Engine
This is Rietveld 408576698