Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2061233002: Remove command buffer sample app support. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove command buffer sample app support. This hasn't compiled for months. We are deemphasizing SampleApp in favor of viewer. Windowed command buffer is not currently something we currently plan to maintain. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2061233002 Committed: https://skia.googlesource.com/skia/+/4999616c3af3ddd38b4d12213eeeaeabee4907c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -124 lines) Patch
M include/views/SkOSWindow_Mac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_SDL.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_Unix.h View 1 chunk +0 lines, -3 lines 0 comments Download
M include/views/SkOSWindow_Win.h View 4 chunks +0 lines, -15 lines 0 comments Download
M samplecode/SampleApp.h View 2 chunks +0 lines, -6 lines 0 comments Download
M samplecode/SampleApp.cpp View 7 chunks +1 line, -26 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 7 chunks +0 lines, -68 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061233002/1
4 years, 6 months ago (2016-06-14 16:26:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/9093)
4 years, 6 months ago (2016-06-14 16:31:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061233002/1
4 years, 6 months ago (2016-06-14 16:36:57 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 16:43:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4999616c3af3ddd38b4d12213eeeaeabee4907c5

Powered by Google App Engine
This is Rietveld 408576698