src/full-codegen/x64/full-codegen-x64.cc - Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Extend context DCHECK Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index f50b0d0896e3c66466147d53c1e8ae8f92f98acb..47083bd2e094d79aa8b110496c2c59031f557982 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -764,7 +764,6 @@ void FullCodeGenerator::VisitVariableDeclaration(

DCHECK(IsDeclaredVariableMode(mode));

DCHECK(!hole_init);

__ Push(Smi::FromInt(0)); // Indicates no initial value.

- __ Push(Smi::FromInt(variable->DeclarationPropertyAttributes()));

__ CallRuntime(Runtime::kDeclareLookupSlot);

PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

break;

@@ -819,7 +818,6 @@ void FullCodeGenerator::VisitFunctionDeclaration(

Comment cmnt(masm_, "[ FunctionDeclaration");

PushOperand(variable->name());

VisitForStackValue(declaration->fun());

- PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes()));

CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);

PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);

break;

« no previous file with comments | « src/full-codegen/mips64/full-codegen-mips64.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | src/interpreter/bytecode-generator.cc » ('J')