Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extend context DCHECK Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc
index dddba9d23da6e118e7987e7f0e714f8b43929101..fe5e85164b198b80a471b23453dc8af54f782417 100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1135,11 +1135,9 @@ void AstGraphBuilder::VisitVariableDeclaration(VariableDeclaration* decl) {
DCHECK(!hole_init);
Node* name = jsgraph()->Constant(variable->name());
Node* value = jsgraph()->ZeroConstant(); // Indicates no initial value.
- Node* attr =
- jsgraph()->Constant(variable->DeclarationPropertyAttributes());
const Operator* op =
javascript()->CallRuntime(Runtime::kDeclareLookupSlot);
- Node* store = NewNode(op, name, value, attr);
+ Node* store = NewNode(op, name, value);
PrepareFrameState(store, decl->proxy()->id());
break;
}
@@ -1178,11 +1176,9 @@ void AstGraphBuilder::VisitFunctionDeclaration(FunctionDeclaration* decl) {
VisitForValue(decl->fun());
Node* value = environment()->Pop();
Node* name = jsgraph()->Constant(variable->name());
- Node* attr =
- jsgraph()->Constant(variable->DeclarationPropertyAttributes());
const Operator* op =
javascript()->CallRuntime(Runtime::kDeclareLookupSlot);
- Node* store = NewNode(op, name, value, attr);
+ Node* store = NewNode(op, name, value);
PrepareFrameState(store, decl->proxy()->id());
break;
}

Powered by Google App Engine
This is Rietveld 408576698