Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extend context DCHECK Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 } 745 }
746 break; 746 break;
747 747
748 case VariableLocation::LOOKUP: { 748 case VariableLocation::LOOKUP: {
749 Comment cmnt(masm_, "[ VariableDeclaration"); 749 Comment cmnt(masm_, "[ VariableDeclaration");
750 __ push(Immediate(variable->name())); 750 __ push(Immediate(variable->name()));
751 // VariableDeclaration nodes are always introduced in one of four modes. 751 // VariableDeclaration nodes are always introduced in one of four modes.
752 DCHECK(IsDeclaredVariableMode(mode)); 752 DCHECK(IsDeclaredVariableMode(mode));
753 DCHECK(!hole_init); 753 DCHECK(!hole_init);
754 __ push(Immediate(Smi::FromInt(0))); // Indicates no initial value. 754 __ push(Immediate(Smi::FromInt(0))); // Indicates no initial value.
755 __ push(
756 Immediate(Smi::FromInt(variable->DeclarationPropertyAttributes())));
757 __ CallRuntime(Runtime::kDeclareLookupSlot); 755 __ CallRuntime(Runtime::kDeclareLookupSlot);
758 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 756 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
759 break; 757 break;
760 } 758 }
761 } 759 }
762 } 760 }
763 761
764 762
765 void FullCodeGenerator::VisitFunctionDeclaration( 763 void FullCodeGenerator::VisitFunctionDeclaration(
766 FunctionDeclaration* declaration) { 764 FunctionDeclaration* declaration) {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 EMIT_REMEMBERED_SET, 798 EMIT_REMEMBERED_SET,
801 OMIT_SMI_CHECK); 799 OMIT_SMI_CHECK);
802 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 800 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
803 break; 801 break;
804 } 802 }
805 803
806 case VariableLocation::LOOKUP: { 804 case VariableLocation::LOOKUP: {
807 Comment cmnt(masm_, "[ FunctionDeclaration"); 805 Comment cmnt(masm_, "[ FunctionDeclaration");
808 PushOperand(variable->name()); 806 PushOperand(variable->name());
809 VisitForStackValue(declaration->fun()); 807 VisitForStackValue(declaration->fun());
810 PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes()));
811 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot); 808 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);
812 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 809 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
813 break; 810 break;
814 } 811 }
815 } 812 }
816 } 813 }
817 814
818 815
819 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) { 816 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
820 // Call the runtime to declare the globals. 817 // Call the runtime to declare the globals.
(...skipping 2889 matching lines...) Expand 10 before | Expand all | Expand 10 after
3710 isolate->builtins()->OnStackReplacement()->entry(), 3707 isolate->builtins()->OnStackReplacement()->entry(),
3711 Assembler::target_address_at(call_target_address, unoptimized_code)); 3708 Assembler::target_address_at(call_target_address, unoptimized_code));
3712 return ON_STACK_REPLACEMENT; 3709 return ON_STACK_REPLACEMENT;
3713 } 3710 }
3714 3711
3715 3712
3716 } // namespace internal 3713 } // namespace internal
3717 } // namespace v8 3714 } // namespace v8
3718 3715
3719 #endif // V8_TARGET_ARCH_IA32 3716 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698