Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Side by Side Diff: src/full-codegen/arm64/full-codegen-arm64.cc

Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extend context DCHECK Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM64 5 #if V8_TARGET_ARCH_ARM64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 785 matching lines...) Expand 10 before | Expand all | Expand 10 after
796 break; 796 break;
797 797
798 case VariableLocation::LOOKUP: { 798 case VariableLocation::LOOKUP: {
799 Comment cmnt(masm_, "[ VariableDeclaration"); 799 Comment cmnt(masm_, "[ VariableDeclaration");
800 __ Mov(x2, Operand(variable->name())); 800 __ Mov(x2, Operand(variable->name()));
801 // Declaration nodes are always introduced in one of four modes. 801 // Declaration nodes are always introduced in one of four modes.
802 DCHECK(IsDeclaredVariableMode(mode)); 802 DCHECK(IsDeclaredVariableMode(mode));
803 DCHECK(!hole_init); 803 DCHECK(!hole_init);
804 // Pushing 0 (xzr) indicates no initial value. 804 // Pushing 0 (xzr) indicates no initial value.
805 __ Push(x2, xzr); 805 __ Push(x2, xzr);
806 __ Push(Smi::FromInt(variable->DeclarationPropertyAttributes()));
807 __ CallRuntime(Runtime::kDeclareLookupSlot); 806 __ CallRuntime(Runtime::kDeclareLookupSlot);
808 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 807 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
809 break; 808 break;
810 } 809 }
811 } 810 }
812 } 811 }
813 812
814 813
815 void FullCodeGenerator::VisitFunctionDeclaration( 814 void FullCodeGenerator::VisitFunctionDeclaration(
816 FunctionDeclaration* declaration) { 815 FunctionDeclaration* declaration) {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
854 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 853 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
855 break; 854 break;
856 } 855 }
857 856
858 case VariableLocation::LOOKUP: { 857 case VariableLocation::LOOKUP: {
859 Comment cmnt(masm_, "[ Function Declaration"); 858 Comment cmnt(masm_, "[ Function Declaration");
860 __ Mov(x2, Operand(variable->name())); 859 __ Mov(x2, Operand(variable->name()));
861 PushOperand(x2); 860 PushOperand(x2);
862 // Push initial value for function declaration. 861 // Push initial value for function declaration.
863 VisitForStackValue(declaration->fun()); 862 VisitForStackValue(declaration->fun());
864 PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes()));
865 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot); 863 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);
866 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 864 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
867 break; 865 break;
868 } 866 }
869 } 867 }
870 } 868 }
871 869
872 870
873 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) { 871 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
874 // Call the runtime to declare the globals. 872 // Call the runtime to declare the globals.
(...skipping 3008 matching lines...) Expand 10 before | Expand all | Expand 10 after
3883 } 3881 }
3884 3882
3885 return INTERRUPT; 3883 return INTERRUPT;
3886 } 3884 }
3887 3885
3888 3886
3889 } // namespace internal 3887 } // namespace internal
3890 } // namespace v8 3888 } // namespace v8
3891 3889
3892 #endif // V8_TARGET_ARCH_ARM64 3890 #endif // V8_TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698