Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2061173002: [cleanup] Remove dead code from DeclareLookupSlot and rename it (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extend context DCHECK Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 788 matching lines...) Expand 10 before | Expand all | Expand 10 after
799 break; 799 break;
800 800
801 case VariableLocation::LOOKUP: { 801 case VariableLocation::LOOKUP: {
802 Comment cmnt(masm_, "[ VariableDeclaration"); 802 Comment cmnt(masm_, "[ VariableDeclaration");
803 __ mov(r2, Operand(variable->name())); 803 __ mov(r2, Operand(variable->name()));
804 // Declaration nodes are always introduced in one of four modes. 804 // Declaration nodes are always introduced in one of four modes.
805 DCHECK(IsDeclaredVariableMode(mode)); 805 DCHECK(IsDeclaredVariableMode(mode));
806 DCHECK(!hole_init); 806 DCHECK(!hole_init);
807 __ mov(r0, Operand(Smi::FromInt(0))); // Indicates no initial value. 807 __ mov(r0, Operand(Smi::FromInt(0))); // Indicates no initial value.
808 __ Push(r2, r0); 808 __ Push(r2, r0);
809 __ Push(Smi::FromInt(variable->DeclarationPropertyAttributes()));
810 __ CallRuntime(Runtime::kDeclareLookupSlot); 809 __ CallRuntime(Runtime::kDeclareLookupSlot);
811 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 810 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
812 break; 811 break;
813 } 812 }
814 } 813 }
815 } 814 }
816 815
817 816
818 void FullCodeGenerator::VisitFunctionDeclaration( 817 void FullCodeGenerator::VisitFunctionDeclaration(
819 FunctionDeclaration* declaration) { 818 FunctionDeclaration* declaration) {
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 856 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
858 break; 857 break;
859 } 858 }
860 859
861 case VariableLocation::LOOKUP: { 860 case VariableLocation::LOOKUP: {
862 Comment cmnt(masm_, "[ FunctionDeclaration"); 861 Comment cmnt(masm_, "[ FunctionDeclaration");
863 __ mov(r2, Operand(variable->name())); 862 __ mov(r2, Operand(variable->name()));
864 PushOperand(r2); 863 PushOperand(r2);
865 // Push initial value for function declaration. 864 // Push initial value for function declaration.
866 VisitForStackValue(declaration->fun()); 865 VisitForStackValue(declaration->fun());
867 PushOperand(Smi::FromInt(variable->DeclarationPropertyAttributes()));
868 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot); 866 CallRuntimeWithOperands(Runtime::kDeclareLookupSlot);
869 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS); 867 PrepareForBailoutForId(proxy->id(), BailoutState::NO_REGISTERS);
870 break; 868 break;
871 } 869 }
872 } 870 }
873 } 871 }
874 872
875 873
876 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) { 874 void FullCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
877 // Call the runtime to declare the globals. 875 // Call the runtime to declare the globals.
(...skipping 2997 matching lines...) Expand 10 before | Expand all | Expand 10 after
3875 DCHECK(interrupt_address == 3873 DCHECK(interrupt_address ==
3876 isolate->builtins()->OnStackReplacement()->entry()); 3874 isolate->builtins()->OnStackReplacement()->entry());
3877 return ON_STACK_REPLACEMENT; 3875 return ON_STACK_REPLACEMENT;
3878 } 3876 }
3879 3877
3880 3878
3881 } // namespace internal 3879 } // namespace internal
3882 } // namespace v8 3880 } // namespace v8
3883 3881
3884 #endif // V8_TARGET_ARCH_ARM 3882 #endif // V8_TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698