Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h

Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h
diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h
index 33f43c20ad57bdea27b98b3b7d8721a4d3dcbb50..9596127476ac4db433c3f5352f4d79efb0d04027 100644
--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h
+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h
@@ -41,7 +41,7 @@ struct VectorTraits<blink::C> {
namespace blink {
// Off-heap vectors always need to be finalized.
-class NeedsFinalizer : public A, public ScriptWrappable {
+class NeedsFinalizer : public A {
public:
void trace(Visitor*);
private:
@@ -58,7 +58,7 @@ private:
};
// On-heap vectors with no inlined objects never need to be finalized.
-class DoesNotNeedFinalizer : public A, public ScriptWrappable {
+class DoesNotNeedFinalizer : public A {
public:
void trace(Visitor*);
private:
@@ -67,7 +67,7 @@ private:
// On-heap vectors with inlined objects that don't need destruction
// don't need to be finalized.
-class AlsoDoesNotNeedFinalizer : public A, public ScriptWrappable {
+class AlsoDoesNotNeedFinalizer : public A {
public:
void trace(Visitor*);
private:

Powered by Google App Engine
This is Rietveld 408576698