Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 206113002: Oilpan: Fix Heap::isConsistentForGC which only checks the heap for one attached thread at this poin… (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Oilpan: Fix Heap::isConsistentForGC which only checks the heap for one attached thread at this point. Thanks for noticing this Peter. :) R=oilpan-reviews@chromium.org, pkasting@chromium.org, zerny@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/heap/Heap.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-20 06:59:10 UTC) #1
Vyacheslav Egorov (Chromium)
lgtm!
6 years, 9 months ago (2014-03-20 07:02:46 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-20 07:10:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/206113002/1
6 years, 9 months ago (2014-03-20 07:10:50 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 07:12:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-20 07:12:43 UTC) #6
Vyacheslav Egorov (Chromium)
The CQ bit was checked by vegorov@chromium.org
6 years, 9 months ago (2014-03-20 07:15:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/206113002/1
6 years, 9 months ago (2014-03-20 07:15:50 UTC) #8
haraken
LGTM
6 years, 9 months ago (2014-03-20 08:17:05 UTC) #9
commit-bot: I haz the power
Change committed as 169635
6 years, 9 months ago (2014-03-20 08:20:03 UTC) #10
wibling-chromium
6 years, 9 months ago (2014-03-20 08:31:14 UTC) #11
Message was sent while issue was closed.
lgtm

Thanks for fixing this:p

Powered by Google App Engine
This is Rietveld 408576698