Chromium Code Reviews Chromium Code Reviews
Issue
2061123005:
Revert of [DomKey] Expose Korean special keys on Korean keyboard layout only (Closed)
DescriptionRevert of [DomKey] Expose Korean special keys on Korean keyboard layout only (patchset #2 id:20001 of https://codereview.chromium.org/2046193002/ )
Reason for revert:
Breaks Windows Unit DrMemory tests. Sorry.
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(5)
First breaking build:
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(5)
Error:
UNADDRESSABLE ACCESS: reading 0x00001d2c-0x00001d30 4 byte(s) within 0x00001d2c-0x00001d30
# 0 system call NtUserLoadKeyboardLayoutEx UNICODE_STRING.Buffer
# 1 USER32.dll!SetSystemCursor +0x6c (0x75780272 <USER32.dll+0x70272>)
# 2 USER32.dll!OpenWindowStationW +0xa7b (0x7576babf <USER32.dll+0x5babf>)
# 3 USER32.dll!LoadKeyboardLayoutW +0x14 (0x7576bb2c <USER32.dll+0x5bb2c>)
# 4 ui::PlatformKeyMapTest_KoreanSpecificKeys_Test::TestBody [ui\events\keycodes\platform_key_map_win_unittest.cc:309]
# 5 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458]
Note: @0:00:18.236 in thread 3168
Suppression (error hash=#54506E6D47A9FB57#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
system call NtUserLoadKeyboardLayoutEx UNICODE_STRING.Buffer
USER32.dll!SetSystemCursor
USER32.dll!OpenWindowStationW
USER32.dll!LoadKeyboardLayoutW
*!ui::PlatformKeyMapTest_KoreanSpecificKeys_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
UNADDRESSABLE ACCESS: reading 0x00001d28-0x00001d2a 2 byte(s) within 0x00001d28-0x00001d2a
# 0 system call NtUserLoadKeyboardLayoutEx UNICODE_STRING.Length
# 1 USER32.dll!SetSystemCursor +0x6c (0x75780272 <USER32.dll+0x70272>)
# 2 USER32.dll!OpenWindowStationW +0xa7b (0x7576babf <USER32.dll+0x5babf>)
# 3 USER32.dll!LoadKeyboardLayoutW +0x14 (0x7576bb2c <USER32.dll+0x5bb2c>)
# 4 ui::PlatformKeyMapTest_KoreanSpecificKeys_Test::TestBody [ui\events\keycodes\platform_key_map_win_unittest.cc:309]
# 5 testing::internal::HandleExceptionsInMethodIfSupported<> [testing\gtest\src\gtest.cc:2458]
Note: @0:00:18.236 in thread 3168
Suppression (error hash=#EBB09B57A8C7AF19#):
For more info on using suppressions see http://dev.chromium.org/developers/how-tos/using-drmemory#TOC-Suppressing-error-reports-from-the-
{
UNADDRESSABLE ACCESS
name=<insert_a_suppression_name_here>
system call NtUserLoadKeyboardLayoutEx UNICODE_STRING.Length
USER32.dll!SetSystemCursor
USER32.dll!OpenWindowStationW
USER32.dll!LoadKeyboardLayoutW
*!ui::PlatformKeyMapTest_KoreanSpecificKeys_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
Original issue's description:
> [DomKey] Expose Korean special keys on Korean keyboard layout only
>
> Korean keyboard has special keys "HangulMode" and "HanjaMode", we should
> only expose them when the system layout is Korean. Otherwise we should
> return "Unidentified".
>
> This matches Firefox and windows virtual key.
>
> Note: This also works with JIS keyboard + Korean layout, because we are
> mapping DomKey based on KeyboardCode instead of DomCode.
>
> BUG=612736
>
> Committed: https://crrev.com/bdcfb5a1816f1bad537d7611c7ccb972b550339c
> Cr-Commit-Position: refs/heads/master@{#399783}
TBR=wez@chromium.org,chongz@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=612736
Committed: https://crrev.com/a9248145f2dca37ab3492980ce884787818223ab
Cr-Commit-Position: refs/heads/master@{#399907}
Patch Set 1 #
Messages
Total messages: 8 (3 generated)
|
||||||||||||||||||||||||||||
