Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
index 18d4a7d55a4ead941772e633b51ff0d8d6742547..93ba5ce71d91e25688834f55c8d6a20dcdc32f59 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
@@ -55,8 +55,9 @@ static void nodeNameAttributeSetter(v8::Local<v8::Value> v8Value, const v8::Func
v8::Local<v8::Object> holder = info.Holder();
TestInterfaceNode* impl = V8TestInterfaceNode::toImpl(holder);
V8StringResource<> cppValue = v8Value;
- if (!cppValue.prepare())
+ if (!cppValue.prepare()) {
return;
+ }
impl->setNodeName(cppValue);
}
@@ -83,8 +84,9 @@ static void stringAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v
v8::Local<v8::Object> holder = info.Holder();
TestInterfaceNode* impl = V8TestInterfaceNode::toImpl(holder);
V8StringResource<> cppValue = v8Value;
- if (!cppValue.prepare())
+ if (!cppValue.prepare()) {
return;
+ }
impl->setStringAttribute(cppValue);
}
@@ -173,8 +175,9 @@ static void reflectStringAttributeAttributeSetter(v8::Local<v8::Value> v8Value,
v8::Local<v8::Object> holder = info.Holder();
Element* impl = V8Element::toImpl(holder);
V8StringResource<> cppValue = v8Value;
- if (!cppValue.prepare())
+ if (!cppValue.prepare()) {
return;
+ }
impl->setAttribute(HTMLNames::reflectstringattributeAttr, cppValue);
}
@@ -202,8 +205,9 @@ static void reflectUrlStringAttributeAttributeSetter(v8::Local<v8::Value> v8Valu
v8::Local<v8::Object> holder = info.Holder();
Element* impl = V8Element::toImpl(holder);
V8StringResource<> cppValue = v8Value;
- if (!cppValue.prepare())
+ if (!cppValue.prepare()) {
return;
+ }
impl->setAttribute(HTMLNames::reflecturlstringattributeAttr, cppValue);
}
@@ -264,8 +268,9 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethod(con
return;
}
optionalBooleanArgument = toBoolean(info.GetIsolate(), info[0], exceptionState);
- if (exceptionState.throwIfNeeded())
+ if (exceptionState.hadException()) {
return;
+ }
}
v8SetReturnValueFast(info, impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument), impl);
}
@@ -292,8 +297,9 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodForM
return;
}
optionalBooleanArgument = toBoolean(info.GetIsolate(), info[0], exceptionState);
- if (exceptionState.throwIfNeeded())
+ if (exceptionState.hadException()) {
return;
+ }
}
v8SetReturnValueForMainWorld(info, impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(optionalBooleanArgument));
}

Powered by Google App Engine
This is Rietveld 408576698