Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
index 6db34446b6cdede7ab6a15e69a9e169582ebce3b..17c179c0b7b10edefdf2eb9aa56fe96f3f8c7e20 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
@@ -74,7 +74,6 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio
ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceNamedConstructor", info.Holder(), info.GetIsolate());
if (UNLIKELY(info.Length() < 1)) {
setMinimumArityTypeError(exceptionState, 1, info.Length());
- exceptionState.throwIfNeeded();
return;
}
V8StringResource<> stringArg;
@@ -91,21 +90,26 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio
--numArgsPassed;
}
stringArg = info[0];
- if (!stringArg.prepare())
+ if (!stringArg.prepare()) {
return;
+ }
defaultUndefinedOptionalBooleanArg = toBoolean(info.GetIsolate(), info[1], exceptionState);
- if (exceptionState.throwIfNeeded())
+ if (exceptionState.hadException()) {
return;
+ }
defaultUndefinedOptionalLongArg = toInt32(info.GetIsolate(), info[2], NormalConversion, exceptionState);
- if (exceptionState.throwIfNeeded())
+ if (exceptionState.hadException()) {
return;
+ }
defaultUndefinedOptionalStringArg = info[3];
- if (!defaultUndefinedOptionalStringArg.prepare())
+ if (!defaultUndefinedOptionalStringArg.prepare()) {
return;
+ }
if (!info[4]->IsUndefined()) {
defaultNullStringOptionalstringArg = info[4];
- if (!defaultNullStringOptionalstringArg.prepare())
+ if (!defaultNullStringOptionalstringArg.prepare()) {
return;
+ }
} else {
defaultNullStringOptionalstringArg = nullptr;
}
@@ -113,7 +117,6 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio
Document& document = *toDocument(currentExecutionContext(info.GetIsolate()));
TestInterfaceNamedConstructor* impl = TestInterfaceNamedConstructor::createForJSConstructor(document, stringArg, defaultUndefinedOptionalBooleanArg, defaultUndefinedOptionalLongArg, defaultUndefinedOptionalStringArg, defaultNullStringOptionalstringArg, exceptionState);
if (exceptionState.hadException()) {
- exceptionState.throwIfNeeded();
return;
}
v8::Local<v8::Object> wrapper = info.Holder();
@@ -122,13 +125,13 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio
return;
}
optionalStringArg = info[5];
- if (!optionalStringArg.prepare())
+ if (!optionalStringArg.prepare()) {
return;
+ }
}
Document& document = *toDocument(currentExecutionContext(info.GetIsolate()));
TestInterfaceNamedConstructor* impl = TestInterfaceNamedConstructor::createForJSConstructor(document, stringArg, defaultUndefinedOptionalBooleanArg, defaultUndefinedOptionalLongArg, defaultUndefinedOptionalStringArg, defaultNullStringOptionalstringArg, optionalStringArg, exceptionState);
if (exceptionState.hadException()) {
- exceptionState.throwIfNeeded();
return;
}
v8::Local<v8::Object> wrapper = info.Holder();

Powered by Google App Engine
This is Rietveld 408576698