Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
index 5abbbd99d0e42e65fce912488b4575d7ca6364bf..12a272c184a13b24dabbbca791fc383047cd42c4 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
@@ -41,8 +41,9 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca
// Do nothing.
} else {
V8StringResource<> derivedStringMember = derivedStringMemberValue;
- if (!derivedStringMember.prepare(exceptionState))
+ if (!derivedStringMember.prepare(exceptionState)) {
return;
+ }
impl.setDerivedStringMember(derivedStringMember);
}
@@ -55,8 +56,9 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca
// Do nothing.
} else {
V8StringResource<> derivedStringMemberWithDefault = derivedStringMemberWithDefaultValue;
- if (!derivedStringMemberWithDefault.prepare(exceptionState))
+ if (!derivedStringMemberWithDefault.prepare(exceptionState)) {
return;
+ }
impl.setDerivedStringMemberWithDefault(derivedStringMemberWithDefault);
}
@@ -70,8 +72,9 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca
return;
} else {
int requiredLongMember = toInt32(isolate, requiredLongMemberValue, NormalConversion, exceptionState);
- if (exceptionState.hadException())
+ if (exceptionState.hadException()) {
return;
+ }
impl.setRequiredLongMember(requiredLongMember);
}
@@ -84,8 +87,9 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca
// Do nothing.
} else {
HeapVector<StringOrDouble> stringOrDoubleSequenceMember = toImplArray<HeapVector<StringOrDouble>>(stringOrDoubleSequenceMemberValue, 0, isolate, exceptionState);
- if (exceptionState.hadException())
+ if (exceptionState.hadException()) {
return;
+ }
impl.setStringOrDoubleSequenceMember(stringOrDoubleSequenceMember);
}

Powered by Google App Engine
This is Rietveld 408576698