third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp - Issue 2061113002: Remove ExceptionState::throwIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

index 71948d7a10cc57fa0192b5e72e27cb23e051411f..ca7e3274d69baa35e7fcb7bcfbc1ae00066ceb3c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp

@@ -84,16 +84,18 @@ void V8TestEnumOrDouble::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Val

if (v8Value->IsNumber()) {

double cppValue = toRestrictedDouble(isolate, v8Value, exceptionState);

- if (exceptionState.hadException())

+ if (exceptionState.hadException()) {

return;

+ }

impl.setDouble(cppValue);

return;

}

{

V8StringResource<> cppValue = v8Value;

- if (!cppValue.prepare(exceptionState))

+ if (!cppValue.prepare(exceptionState)) {

return;

+ }

const char* validValues[] = {

"",

"EnumValue1",