third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp - Issue 2061113002: Remove ExceptionState::throwIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

index fc4c3d704e2a23e9027e44b6a8533769cdc6d468..4b5677e5a7ac3b72eee59d603bec14324257b2b7 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

@@ -86,7 +86,7 @@ void V8Document::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& inf

ExceptionState exceptionState(ExceptionState::ExecutionContext, "open", "Document", info.Holder(), info.GetIsolate());

document->open(enteredDOMWindow(info.GetIsolate())->document(), exceptionState);

- if (exceptionState.throwIfNeeded())

+ if (exceptionState.hadException())

return;

v8SetReturnValue(info, info.Holder());