third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 2061113002: Remove ExceptionState::throwIfNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ExceptionState.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index 68f47f322817a4a20bf0b42176e7b9f68f86d5da..6520320d84ec4a4c31f6e2fbdfe85e3c7356792b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -276,7 +276,6 @@ static void failedAccessCheckCallbackInMainThread(v8::Local<v8::Object> host, v8

// FIXME: We should modify V8 to pass in more contextual information (context, property, and object).

ExceptionState exceptionState(ExceptionState::UnknownContext, 0, 0, isolate->GetCurrentContext()->Global(), isolate);

exceptionState.throwSecurityError(targetWindow->sanitizedCrossDomainAccessErrorMessage(currentDOMWindow(isolate)), targetWindow->crossDomainAccessErrorMessage(currentDOMWindow(isolate)));

- exceptionState.throwIfNeeded();

}

static bool codeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context)