Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/utilities.cpp

Issue 2061113002: Remove ExceptionState::throwIfNeeded Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro v8_value_to_local_cpp_value(thing) %} 1 {% macro v8_value_to_local_cpp_value(thing) %}
2 {# This indirection is just to avoid spurious white-space lines. #} 2 {# This indirection is just to avoid spurious white-space lines. #}
3 {{generate_v8_value_to_local_cpp_value(thing) | trim}} 3 {{generate_v8_value_to_local_cpp_value(thing) | trim}}
4 {%- endmacro %} 4 {%- endmacro %}
5 5
6 6
7 {% macro generate_v8_value_to_local_cpp_value(thing) %} 7 {% macro generate_v8_value_to_local_cpp_value(thing) %}
8 {% set item = thing.v8_value_to_local_cpp_value or thing %} 8 {% set item = thing.v8_value_to_local_cpp_value or thing %}
9 {% if item.error_message %} 9 {% if item.error_message %}
10 /* {{item.error_message}} */ 10 /* {{item.error_message}} */
11 {% else %} 11 {% else %}
12 {% if item.declare_variable %} 12 {% if item.declare_variable %}
13 {% if item.assign_expression %} 13 {% if item.assign_expression %}
14 {{item.cpp_type}} {{item.cpp_name}} = {{item.assign_expression}}; 14 {{item.cpp_type}} {{item.cpp_name}} = {{item.assign_expression}};
15 {% else %} 15 {% else %}
16 {{item.cpp_type}} {{item.cpp_name}}; 16 {{item.cpp_type}} {{item.cpp_name}};
17 {% endif %} 17 {% endif %}
18 {% else %}{# item.declare_variable #} 18 {% else %}{# item.declare_variable #}
19 {% if item.assign_expression %} 19 {% if item.assign_expression %}
20 {{item.cpp_name}} = {{item.assign_expression}}; 20 {{item.cpp_name}} = {{item.assign_expression}};
21 {% endif %} 21 {% endif %}
22 {% endif %}{# item.declare_variable #} 22 {% endif %}{# item.declare_variable #}
23 {% if item.set_expression %} 23 {% if item.set_expression %}
24 {{item.set_expression}}; 24 {{item.set_expression}};
25 {% endif %} 25 {% endif %}
26 {% if item.check_expression %} 26 {% if item.check_expression %}
27 if ({{item.check_expression}}) 27 if ({{item.check_expression}}) {
28 {% if item.clear_exception %}{{item.clear_exception}};{% endif %}
28 return{% if item.return_expression %} {{item.return_expression}}{% endif %}; 29 return{% if item.return_expression %} {{item.return_expression}}{% endif %};
30 }
29 {% endif %}{# item.check_expression #} 31 {% endif %}{# item.check_expression #}
30 {% endif %}{# item.error_message #} 32 {% endif %}{# item.error_message #}
31 {% endmacro %} 33 {% endmacro %}
32 34
33 35
34 {% macro declare_enum_validation_variable(enum_values) %} 36 {% macro declare_enum_validation_variable(enum_values) %}
35 const char* validValues[] = { 37 const char* validValues[] = {
36 {% for enum_value in enum_values %} 38 {% for enum_value in enum_values %}
37 "{{enum_value}}", 39 "{{enum_value}}",
38 {% endfor %} 40 {% endfor %}
(...skipping 20 matching lines...) Expand all
59 ExecutionContext* executionContext = currentExecutionContext({{isolate}}); 61 ExecutionContext* executionContext = currentExecutionContext({{isolate}});
60 String errorMessage; 62 String errorMessage;
61 if (!{{member.origin_trial_enabled_function}}(executionContext, errorMessage)) { 63 if (!{{member.origin_trial_enabled_function}}(executionContext, errorMessage)) {
62 v8SetReturnValue(info, v8::Undefined(info.GetIsolate())); 64 v8SetReturnValue(info, v8::Undefined(info.GetIsolate()));
63 if (!errorMessage.isEmpty()) { 65 if (!errorMessage.isEmpty()) {
64 executionContext->addConsoleMessage(ConsoleMessage::create(JSMessageSour ce, ErrorMessageLevel, errorMessage)); 66 executionContext->addConsoleMessage(ConsoleMessage::create(JSMessageSour ce, ErrorMessageLevel, errorMessage));
65 } 67 }
66 return; 68 return;
67 } 69 }
68 {% endmacro %} 70 {% endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698