Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2061023003: git_cl: stop using deprecated except syntax (Closed)

Created:
4 years, 6 months ago by vapier
Modified:
4 years, 6 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git_cl: stop using deprecated except syntax The newer form works with python2 and python3. Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/fd77ac7c7762aedd9abbf7c2ff4f2cbdd7256d80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M git_cl.py View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
vapier
4 years, 6 months ago (2016-06-14 15:57:40 UTC) #2
tandrii(chromium)
LGTM btw, have you tried running the tests (tests/git_cl_test.py) in Py3 mode?
4 years, 6 months ago (2016-06-14 16:05:24 UTC) #3
vapier
not yet ... can't get `git cl` to work yet as it imports other modules ...
4 years, 6 months ago (2016-06-14 16:52:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061023003/1
4 years, 6 months ago (2016-06-14 16:52:55 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Depot Tools Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/602)
4 years, 6 months ago (2016-06-14 16:59:11 UTC) #8
tandrii(chromium)
On 2016/06/14 16:59:11, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-14 18:42:16 UTC) #9
vapier
thanks ... thought it weird the output was diff for this CL
4 years, 6 months ago (2016-06-14 21:25:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061023003/1
4 years, 6 months ago (2016-06-16 15:30:27 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 15:34:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/fd77ac7c7762ae...

Powered by Google App Engine
This is Rietveld 408576698