wayland: Fix GetUserDataAs in remote_shell_get_remote_surface

wayland: Fix GetUserDataAs in remote_shell_get_remote_surface

GetUserDataAs<T> needs to be consistent with SetImplementation.
WaylandRemoteShell instance is associated with WaylandRemoteShell
and that is what GetUserDataAs<T> gets back.

BUG=None

Committed: https://crrev.com/8430411773ff2f7ffc3d64f4602a527c54846ec1
Cr-Commit-Position: refs/heads/master@{#399588}

[xiyuan, 2016-06-13 21:10:02]

xiyuan@chromium.org changed reviewers:
+ reveman@chromium.org

[reveman, 2016-06-13 21:44:56]

lgtm % nits

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1502: WaylandRemoteShell(Display* exo_display,
nit: s/exo_display/display/

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1503: const display::Display& display,
nit: s/const display::Display& display/int64_t display_id/ as we're not using
anything but the id anyhow

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1505: : exo_display_(exo_display),
nit: display_(display)

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1521: std::unique_ptr<ShellSurface>
CreateRemoteShellSurface(Surface* surface,
nit: "Remote" could be removed from the name here as it's implicit from the
class name but fine to leave this as is too

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1593: Display* const exo_display_;
nit: s/exo_display_/display_/

[xiyuan, 2016-06-13 22:08:10]

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1502: WaylandRemoteShell(Display* exo_display,
On 2016/06/13 21:44:56, reveman wrote:
> nit: s/exo_display/display/

Done.

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1503: const display::Display& display,
On 2016/06/13 21:44:56, reveman wrote:
> nit: s/const display::Display& display/int64_t display_id/ as we're not using
> anything but the id anyhow

Done.

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1505: : exo_display_(exo_display),
On 2016/06/13 21:44:56, reveman wrote:
> nit: display_(display)

Done.

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1521: std::unique_ptr<ShellSurface>
CreateRemoteShellSurface(Surface* surface,
On 2016/06/13 21:44:56, reveman wrote:
> nit: "Remote" could be removed from the name here as it's implicit from the
> class name but fine to leave this as is too

Done.

https://codereview.chromium.org/2061023002/diff/1/components/exo/wayland/serv...
components/exo/wayland/server.cc:1593: Display* const exo_display_;
On 2016/06/13 21:44:56, reveman wrote:
> nit: s/exo_display_/display_/

Done.

[xiyuan, 2016-06-13 22:08:28]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2016-06-13 22:08:29]

The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2061023002/#ps20001
(title: "address nits")

[commit-bot: I haz the power, 2016-06-13 22:09:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061023002/20001

[commit-bot: I haz the power, 2016-06-13 22:53:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-13 22:53:35]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 22:56:19]

Description was changed from

==========
wayland: Fix GetUserDataAs in remote_shell_get_remote_surface

GetUserDataAs<T> needs to be consistent with SetImplementation.
WaylandRemoteShell instance is associated with WaylandRemoteShell
and that is what GetUserDataAs<T> gets back.

BUG=None
==========

to

==========
wayland: Fix GetUserDataAs in remote_shell_get_remote_surface

GetUserDataAs<T> needs to be consistent with SetImplementation.
WaylandRemoteShell instance is associated with WaylandRemoteShell
and that is what GetUserDataAs<T> gets back.

BUG=None

Committed: https://crrev.com/8430411773ff2f7ffc3d64f4602a527c54846ec1
Cr-Commit-Position: refs/heads/master@{#399588}
==========

[commit-bot: I haz the power, 2016-06-13 22:56:20]

Patchset 2 (id:??) landed as
https://crrev.com/8430411773ff2f7ffc3d64f4602a527c54846ec1
Cr-Commit-Position: refs/heads/master@{#399588}