Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2061003002: Build rule for pdf_css_fuzzer (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Oliver Chang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build rule for pdf_css_fuzzer Add the Chromium side build rules for the css fuzzer. BUG=chromium:587126 Committed: https://crrev.com/906c3a8f3e2ab28d04c231fe2c0f33717da7c10a Cr-Commit-Position: refs/heads/master@{#400209}

Patch Set 1 #

Patch Set 2 : Add css fuzzer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M pdf/pdfium/fuzzers/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
A pdf/pdfium/fuzzers/dicts/pdf_css.dict View 1 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
dsinclair
PTAL. This can't commit until https://codereview.chromium.org/2068513002/ lands and rolls into Chromium. But, wanted to get ...
4 years, 6 months ago (2016-06-13 20:08:59 UTC) #2
Oliver Chang
On 2016/06/13 20:08:59, dsinclair wrote: > PTAL. This can't commit until https://codereview.chromium.org/2068513002/ lands > and ...
4 years, 6 months ago (2016-06-13 20:21:44 UTC) #3
dsinclair
like so?
4 years, 6 months ago (2016-06-14 14:39:20 UTC) #4
Oliver Chang
lgtm, thanks
4 years, 6 months ago (2016-06-14 15:28:27 UTC) #5
dsinclair
thestig@ for OWNERS
4 years, 6 months ago (2016-06-16 14:27:34 UTC) #7
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-16 17:21:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061003002/20001
4 years, 6 months ago (2016-06-16 17:22:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 18:21:48 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 18:21:59 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 18:23:16 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/906c3a8f3e2ab28d04c231fe2c0f33717da7c10a
Cr-Commit-Position: refs/heads/master@{#400209}

Powered by Google App Engine
This is Rietveld 408576698