Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2060983004: Revert of Added comprehensive tests for views::Border. (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
Reviewers:
danakj, sadrul, Matt Giuca
CC:
chromium-reviews, tfarina, danakj, Ben Goodger (Google), chrome-apps-syd-reviews_chromium.org, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Added comprehensive tests for views::Border. (patchset #13 id:260001 of https://codereview.chromium.org/1517463003/ ) Reason for revert: This CL causes Win x64 Builder failure on chromium.perf. https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/builds/9544 [5442/5460] LINK(DLL) chrome.dll chrome.dll.lib FAILED: chrome.dll chrome.dll.lib C:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:./chrome.dll.lib /DLL /OUT:./chrome.dll /PDB:./chrome.dll.pdb @./chrome.dll.rsp obj/chrome/browser/ui/ui.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0x14B19402 [5443/5460] LINK(DLL) chrome_child.dll chrome_child.dll.lib ninja: build stopped: subcommand failed. BUG=619949 Original issue's description: > Added comprehensive tests for views::Border. > > BUG=568389 > > Committed: https://crrev.com/92614dc154ad143a1ef9849ae0fe90c02df09f30 > Cr-Commit-Position: refs/heads/master@{#399650} TBR=sadrul@chromium.org,danakj@chromium.org,mgiuca@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568389 Committed: https://crrev.com/25722a4a11f04300296119496fcc644a4fb03667 Cr-Commit-Position: refs/heads/master@{#399709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -256 lines) Patch
D ui/views/border_unittest.cc View 1 chunk +0 lines, -255 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Zhen Wang
Created Revert of Added comprehensive tests for views::Border.
4 years, 6 months ago (2016-06-14 15:18:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060983004/1
4 years, 6 months ago (2016-06-14 15:18:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 15:19:03 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 15:19:20 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 15:52:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25722a4a11f04300296119496fcc644a4fb03667
Cr-Commit-Position: refs/heads/master@{#399709}

Powered by Google App Engine
This is Rietveld 408576698