Quick View: Add functinoality to show generic metadata (size and modificationTime).

Quick View: Add functinoality to show generic metadata (size and modificationTime).
Demo(internal): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde
Cr-Commit-Position: refs/heads/master@{#399863}

[oka, 2016-06-14 11:30:05]

Description was changed from

==========
Satisfy closure compiler.


Add functinoality to show generic metadata (size and modificationTime).

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Add functinoality to show generic metadata (size and modificationTime).

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

[oka, 2016-06-14 11:38:06]

nit

[oka, 2016-06-14 11:46:11]

Description was changed from

==========
Add functinoality to show generic metadata (size and modificationTime).

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Add functinoality to show generic metadata (size and modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

[oka, 2016-06-14 11:46:11]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-06-14 11:46:54]

Description was changed from

==========
Add functinoality to show generic metadata (size and modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add functinoality to show generic metadata (size and
modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

[fukino, 2016-06-14 23:09:42]

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.html:14:
position: absolute;
style: sort properties.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:8: <link
rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
We use iron-iconset-svg instead of iron-icons to reduce Chrome size.
Please refer to https://codereview.chromium.org/1990803003/, which removed
iron-icons from files app.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:36:
margin: 0;
style: sort properties

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:1: //
Copyright (c) 2016 The Chromium Authors. All rights reserved.
remove (c).

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:27:
this.metadataBox_ = metadataBox;
style: insert a blank line.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:32:
this.quickView_ = quickView;
ditto

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:57: *
Update the view of metadata box.
@private

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:74: *
@param{!Array<!MetadataItem>} items
@private

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_model.js (right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
remove (c)

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:15: *
@type{FileEntry}
space after @type

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:26:
QuickViewModel.prototype.getSelectedEntry = function() {
Add annotation.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/manifest.json (right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/manifest.json:165:
"foreground/elements/files_metadata_box.html",
I think files_metadata_box.* and files_quick_view.* don't have to be added here.

[oka, 2016-06-14 23:54:49]

Address comments.

[oka, 2016-06-14 23:58:24]

Nit

[oka, 2016-06-14 23:59:49]

PTAL

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_box.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.html:14:
position: absolute;
On 2016/06/14 23:09:41, fukino wrote:
> style: sort properties.

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:8: <link
rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2016/06/14 23:09:41, fukino wrote:
> We use iron-iconset-svg instead of iron-icons to reduce Chrome size.
> Please refer to https://codereview.chromium.org/1990803003/, which removed
> iron-icons from files app.

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:36:
margin: 0;
On 2016/06/14 23:09:41, fukino wrote:
> style: sort properties

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/metadata_box_controller.js
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:1: //
Copyright (c) 2016 The Chromium Authors. All rights reserved.
On 2016/06/14 23:09:41, fukino wrote:
> remove (c).

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:27:
this.metadataBox_ = metadataBox;
On 2016/06/14 23:09:42, fukino wrote:
> style: insert a blank line.

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:32:
this.quickView_ = quickView;
On 2016/06/14 23:09:41, fukino wrote:
> ditto

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:57: *
Update the view of metadata box.
On 2016/06/14 23:09:42, fukino wrote:
> @private

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/metadata_box_controller.js:74: *
@param{!Array<!MetadataItem>} items
On 2016/06/14 23:09:42, fukino wrote:
> @private

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_model.js (right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/06/14 23:09:42, fukino wrote:
> remove (c)

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:15: *
@type{FileEntry}
On 2016/06/14 23:09:42, fukino wrote:
> space after @type

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_model.js:26:
QuickViewModel.prototype.getSelectedEntry = function() {
On 2016/06/14 23:09:42, fukino wrote:
> Add annotation.

Done.

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/manifest.json (right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/manifest.json:165:
"foreground/elements/files_metadata_box.html",
On 2016/06/14 23:09:42, fukino wrote:
> I think files_metadata_box.* and files_quick_view.* don't have to be added
here.

Done.

[fukino, 2016-06-15 02:16:42]

lgtm with nits

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:8: <link
rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2016/06/14 23:59:49, oka wrote:
> On 2016/06/14 23:09:41, fukino wrote:
> > We use iron-iconset-svg instead of iron-icons to reduce Chrome size.
> > Please refer to https://codereview.chromium.org/1990803003/, which removed
> > iron-icons from files app.
> 
> Done.

iron-icon should be removed, since it is used in this element.

https://codereview.chromium.org/2060983003/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.js
(right):

https://codereview.chromium.org/2060983003/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:69: 
unnecessary blank line

[oka, 2016-06-15 08:07:14]

nit

[oka, 2016-06-15 08:07:28]

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.html
(right):

https://codereview.chromium.org/2060983003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.html:8: <link
rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2016/06/15 02:16:42, fukino wrote:
> On 2016/06/14 23:59:49, oka wrote:
> > On 2016/06/14 23:09:41, fukino wrote:
> > > We use iron-iconset-svg instead of iron-icons to reduce Chrome size.
> > > Please refer to https://codereview.chromium.org/1990803003/, which removed
> > > iron-icons from files app.
> > 
> > Done.
> 
> iron-icon should be removed, since it is used in this element.

Done.

https://codereview.chromium.org/2060983003/diff/80001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_quick_view.js
(right):

https://codereview.chromium.org/2060983003/diff/80001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_quick_view.js:69: 
On 2016/06/15 02:16:42, fukino wrote:
> unnecessary blank line

Done.

[oka, 2016-06-15 08:07:35]

The CQ bit was checked by oka@chromium.org

[oka, 2016-06-15 08:07:35]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2060983003/#ps100001
(title: "nit")

[commit-bot: I haz the power, 2016-06-15 08:07:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060983003/100001

[commit-bot: I haz the power, 2016-06-15 08:45:42]

Description was changed from

==========
Quick View: Add functinoality to show generic metadata (size and
modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add functinoality to show generic metadata (size and
modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

[commit-bot: I haz the power, 2016-06-15 08:45:43]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-15 08:47:03]

Description was changed from

==========
Quick View: Add functinoality to show generic metadata (size and
modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler
==========

to

==========
Quick View: Add functinoality to show generic metadata (size and
modificationTime).
Demo(internal):
https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhbzhpSWRsQVZETFE/view

BUG=613465
TESTED=manually
third_party/closure_compiler/run_compiler

Committed: https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde
Cr-Commit-Position: refs/heads/master@{#399863}
==========

[commit-bot: I haz the power, 2016-06-15 08:47:05]

Patchset 6 (id:??) landed as
https://crrev.com/328d1470a1ee70d688f24d1eca3c51078ad2cdde
Cr-Commit-Position: refs/heads/master@{#399863}