core/fpdfapi/fpdf_page/include/cpdf_formobject.h - Issue 2060973002: Make code compile with clang_use_chrome_plugin (part I)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/include/cpdf_formobject.h

Issue 2060973002: Make code compile with clang_use_chrome_plugin (part I) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/include/cpdf_formobject.h

diff --git a/core/fpdfapi/fpdf_page/include/cpdf_formobject.h b/core/fpdfapi/fpdf_page/include/cpdf_formobject.h

index b12d68c3125725bb1a236305364bc3ac50084482..1a8db34e8f1faaff5a3429ff5b688f6dc7a3e913 100644

--- a/core/fpdfapi/fpdf_page/include/cpdf_formobject.h

+++ b/core/fpdfapi/fpdf_page/include/cpdf_formobject.h

@@ -19,11 +19,11 @@ class CPDF_FormObject : public CPDF_PageObject {

// CPDF_PageObject:

CPDF_FormObject* Clone() const override;

- Type GetType() const override { return FORM; };

+ Type GetType() const override;

void Transform(const CFX_Matrix& matrix) override;

- bool IsForm() const override { return true; };

- CPDF_FormObject* AsForm() override { return this; };

- const CPDF_FormObject* AsForm() const override { return this; };

+ bool IsForm() const override;

+ CPDF_FormObject* AsForm() override;

+ const CPDF_FormObject* AsForm() const override;

void CalcBoundingBox();