core/fpdfapi/fpdf_page/cpdf_shadingpattern.h - Issue 2060973002: Make code compile with clang_use_chrome_plugin (part I)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_page/cpdf_shadingpattern.h

Issue 2060973002: Make code compile with clang_use_chrome_plugin (part I) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_page/cpdf_shadingpattern.h

diff --git a/core/fpdfapi/fpdf_page/cpdf_shadingpattern.h b/core/fpdfapi/fpdf_page/cpdf_shadingpattern.h

index f5cef17fb1d69c88a05e3e3dce46a704184b6dbf..7fe2cc6c79be257332e06eb3104befad6732c0c7 100644

--- a/core/fpdfapi/fpdf_page/cpdf_shadingpattern.h

+++ b/core/fpdfapi/fpdf_page/cpdf_shadingpattern.h

@@ -40,8 +40,8 @@ class CPDF_ShadingPattern : public CPDF_Pattern {

const CFX_Matrix& parentMatrix);

~CPDF_ShadingPattern() override;

- CPDF_TilingPattern* AsTilingPattern() override { return nullptr; }

- CPDF_ShadingPattern* AsShadingPattern() override { return this; }

+ CPDF_TilingPattern* AsTilingPattern() override;

+ CPDF_ShadingPattern* AsShadingPattern() override;

bool IsMeshShading() const {

return m_ShadingType == kFreeFormGouraudTriangleMeshShading ||