Fix compilation with clang shipped with Xcode.

Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673
Committed: https://crrev.com/7d77d2274c07224580b060a49399215ce0ebce1f
Cr-Commit-Position: refs/heads/master@{#400135}

[sdefresne, 2016-06-16 11:29:45]

Description was changed from

==========
Avoid constructing const POD objects.

The C++ standard (section 8.5) says:
> If a program calls for the default initialization of an object of a
> const-qualified type T, T shall be a class type with a user-provided
> default constructor.

This is because otherwiser your type T is a POD and is uninitialised
when constructed leaving all member fields with undeterminate value
and accessing them is undefined behaviour.

With https://codereview.chromium.org/2051343002, gfx::RectF is now a
POD type as it has only default constructor and all its fields too
(recursively) and cause a warning when a const instance is default
constructed with some version of clang.

Use a temporary non const instance instead to avoid the compilation
warning, the object is still with undeterminate content, but it is
fine as none of its fields are ever read.

BUG=620673
==========

to

==========
Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673
==========

[sdefresne, 2016-06-16 11:29:45]

sdefresne@chromium.org changed reviewers:
+ pkasting@chromium.org, vabr@chromium.org

[sdefresne, 2016-06-16 11:30:26]

Please take a look, pkasting as original author of referenced CL, vabr as OWNERS
of components/autofill.

[vabr (Chromium), 2016-06-16 11:38:48]

LGTM, the new code actually seems better to me even without considering the
compiler issue.

Thanks!
Vaclav

[sdefresne, 2016-06-16 11:53:00]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-06-16 11:53:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060943008/1

[commit-bot: I haz the power, 2016-06-16 12:13:19]

Description was changed from

==========
Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673
==========

to

==========
Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673
==========

[commit-bot: I haz the power, 2016-06-16 12:13:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-16 12:13:26]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 12:14:49]

Description was changed from

==========
Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673
==========

to

==========
Fix compilation with clang shipped with Xcode.

After https://codereview.chromium.org/2051343002, the version of
clang shipped with Xcode gets confused and think that gfx::RectF
is a POD type and warns about constructing a const POD value.

Workaround this by passing a temporary non-const value instead.

BUG=620673

Committed: https://crrev.com/7d77d2274c07224580b060a49399215ce0ebce1f
Cr-Commit-Position: refs/heads/master@{#400135}
==========

[commit-bot: I haz the power, 2016-06-16 12:14:50]

Patchset 1 (id:??) landed as
https://crrev.com/7d77d2274c07224580b060a49399215ce0ebce1f
Cr-Commit-Position: refs/heads/master@{#400135}