Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2060943005: Enable content embedder register mojo services with RPH-specific information. (Closed)

Created:
4 years, 6 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nasko+codewatch_chromium.org, jam, timvolodine, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable content embedder register mojo services with RPH-specific information. Just be equivalent with ContentBrowserClient::RegisterRenderFrameMojoServices() providing RenderFrameHost, let ContentBrowserClient::RegisterRenderProcessMojoServices() also provide RenderProcessHost. This way will enable embedder bind some RPH-specific information when registering mojo services. BUG=None Committed: https://crrev.com/0b61879559c9c6d768d7c13b8ad25eebc2b2437d Cr-Commit-Position: refs/heads/master@{#400073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M blimp/engine/app/blimp_content_browser_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/app/blimp_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/battery_status/battery_monitor_integration_browsertest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060943005/1
4 years, 6 months ago (2016-06-15 11:05:58 UTC) #2
leonhsl(Using Gerrit)
Hi, would you PTAL at this? Thanks. This CL comes up from Anand's kindly suggestion ...
4 years, 6 months ago (2016-06-15 11:32:27 UTC) #4
Anand Mistry (off Chromium)
lgtm
4 years, 6 months ago (2016-06-15 11:44:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 12:13:06 UTC) #7
jam
lgtm
4 years, 6 months ago (2016-06-15 18:40:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2060943005/1
4 years, 6 months ago (2016-06-16 01:40:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 01:54:03 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 01:54:30 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 01:55:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b61879559c9c6d768d7c13b8ad25eebc2b2437d
Cr-Commit-Position: refs/heads/master@{#400073}

Powered by Google App Engine
This is Rietveld 408576698