Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: content/browser/media/pepper/pepper_web_contents_observer.h

Issue 2060933002: Let Flash join and be controlled by media session (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pepper_to_contents
Patch Set: added TODO Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_RENDER_PEPPER_PEPPER_WEB_CONTENTS_OBSERVER_H_
6 #define CONTENT_RENDER_PEPPER_PEPPER_WEB_CONTENTS_OBSERVER_H_
7
8 #include "content/public/browser/web_contents_observer.h"
9
10 #include <map>
11 #include <memory>
12
13 namespace content {
14 class PepperPlayerDelegate;
mlamouri (slow - plz ping) 2016/06/23 13:23:20 style: leave empty line above.
Zhiqiang Zhang (Slow) 2016/06/24 17:43:20 Done.
15 class MediaSession;
16
17 class CONTENT_EXPORT PepperWebContentsObserver : public WebContentsObserver {
mlamouri (slow - plz ping) 2016/06/23 13:23:20 Why CONTENT_EXPORT?
Zhiqiang Zhang (Slow) 2016/06/24 17:43:20 Removed.
18 public:
19 explicit PepperWebContentsObserver(WebContents* web_contents);
20 ~PepperWebContentsObserver() override;
21
22 void WebContentsDestroyed() override;
23 void PepperInstanceCreated(int32_t pp_instance) override;
24 void PepperInstanceDeleted(int32_t pp_instance) override;
25 bool OnMessageReceived(const IPC::Message& msg,
26 RenderFrameHost* render_frame_host) override;
27 void OnPepperStartsPlayback(int32_t pp_instance);
28 void OnPepperStopsPlayback(int32_t pp_instance);
29
30 private:
31
32 using PlayersMap =
33 std::map<int32_t, std::unique_ptr<PepperPlayerDelegate>>;
34 PlayersMap players_map_;
35 MediaSession* media_session_;
mlamouri (slow - plz ping) 2016/06/23 13:23:20 FWIW, I don't think you need this. You could as we
Zhiqiang Zhang (Slow) 2016/06/24 17:43:21 Done.
36
37 DISALLOW_COPY_AND_ASSIGN(PepperWebContentsObserver);
38 };
39 }
mlamouri (slow - plz ping) 2016/06/23 13:23:20 style: add empty line above and " // namespace co
Zhiqiang Zhang (Slow) 2016/06/24 17:43:21 Done.
40
41 #endif // CONTENT_RENDER_PEPPER_PEPPER_WEB_CONTENTS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698