Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: Source/core/frame/ConsoleBase.h

Issue 206093005: Oilpan: move Console objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make ConsoleBase::trace() a pure virtual Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/Console.h ('k') | Source/core/frame/ConsoleBase.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/ConsoleBase.h
diff --git a/Source/core/frame/ConsoleBase.h b/Source/core/frame/ConsoleBase.h
index 30858d02731c7ea1f4b7b848787a6a7801eec62b..228b794ff73e6a90cceafaaac18a2c09591e311f 100644
--- a/Source/core/frame/ConsoleBase.h
+++ b/Source/core/frame/ConsoleBase.h
@@ -36,6 +36,7 @@
#include "core/inspector/ScriptCallStack.h"
#include "core/frame/ConsoleTypes.h"
#include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefCounted.h"
@@ -44,11 +45,8 @@ namespace WebCore {
class ScriptArguments;
-class ConsoleBase {
+class ConsoleBase : public RefCountedWillBeGarbageCollectedFinalized<ConsoleBase> {
public:
- void ref() { refConsole(); }
- void deref() { derefConsole(); }
-
void debug(ScriptState*, PassRefPtr<ScriptArguments>);
void error(ScriptState*, PassRefPtr<ScriptArguments>);
void info(ScriptState*, PassRefPtr<ScriptArguments>);
@@ -73,15 +71,15 @@ public:
void groupCollapsed(ScriptState*, PassRefPtr<ScriptArguments>);
void groupEnd();
-protected:
+ virtual void trace(Visitor*) = 0;
+
virtual ~ConsoleBase();
+
+protected:
virtual ExecutionContext* context() = 0;
virtual void reportMessageToClient(MessageLevel, const String& message, PassRefPtr<ScriptCallStack>) = 0;
private:
- virtual void refConsole() = 0;
- virtual void derefConsole() = 0;
-
void internalAddMessage(MessageType, MessageLevel, ScriptState*, PassRefPtr<ScriptArguments>, bool acceptNoArguments = false, bool printTrace = false);
};
« no previous file with comments | « Source/core/frame/Console.h ('k') | Source/core/frame/ConsoleBase.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698