Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: Source/core/frame/Console.h

Issue 206093005: Oilpan: move Console objects to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make ConsoleBase::trace() a pure virtual Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/frame/ConsoleBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 15 matching lines...) Expand all
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #ifndef Console_h 29 #ifndef Console_h
30 #define Console_h 30 #define Console_h
31 31
32 #include "bindings/v8/ScriptState.h" 32 #include "bindings/v8/ScriptState.h"
33 #include "bindings/v8/ScriptWrappable.h" 33 #include "bindings/v8/ScriptWrappable.h"
34 #include "core/frame/ConsoleBase.h" 34 #include "core/frame/ConsoleBase.h"
35 #include "core/frame/DOMWindowProperty.h" 35 #include "core/frame/DOMWindowProperty.h"
36 #include "heap/Handle.h"
36 #include "wtf/Forward.h" 37 #include "wtf/Forward.h"
37 #include "wtf/PassRefPtr.h" 38 #include "wtf/PassRefPtr.h"
38 #include "wtf/RefCounted.h" 39 #include "wtf/RefCounted.h"
39 40
40 namespace WebCore { 41 namespace WebCore {
41 42
42 class LocalFrame; 43 class LocalFrame;
43 class MemoryInfo; 44 class MemoryInfo;
44 class Page; 45 class Page;
45 class ScriptArguments; 46 class ScriptArguments;
46 47
47 class Console FINAL : public RefCounted<Console>, public ConsoleBase, public Scr iptWrappable, public DOMWindowProperty { 48 class Console FINAL : public ConsoleBase, public ScriptWrappable, public DOMWind owProperty {
48 public: 49 public:
49 using RefCounted<Console>::ref; 50 static PassRefPtrWillBeRawPtr<Console> create(LocalFrame* frame)
50 using RefCounted<Console>::deref; 51 {
51 52 return adoptRefWillBeNoop(new Console(frame));
52 static PassRefPtr<Console> create(LocalFrame* frame) { return adoptRef(new C onsole(frame)); } 53 }
53 virtual ~Console(); 54 virtual ~Console();
54 55
55 PassRefPtrWillBeRawPtr<MemoryInfo> memory() const; 56 PassRefPtrWillBeRawPtr<MemoryInfo> memory() const;
56 57
58 void trace(Visitor*) { }
59
57 protected: 60 protected:
58 virtual ExecutionContext* context() OVERRIDE; 61 virtual ExecutionContext* context() OVERRIDE;
59 virtual void reportMessageToClient(MessageLevel, const String& message, Pass RefPtr<ScriptCallStack>) OVERRIDE; 62 virtual void reportMessageToClient(MessageLevel, const String& message, Pass RefPtr<ScriptCallStack>) OVERRIDE;
60 63
61 private: 64 private:
62 explicit Console(LocalFrame*); 65 explicit Console(LocalFrame*);
63
64 virtual void refConsole() OVERRIDE { ref(); }
65 virtual void derefConsole() OVERRIDE { deref(); }
66 }; 66 };
67 67
68 } // namespace WebCore 68 } // namespace WebCore
69 69
70 #endif // Console_h 70 #endif // Console_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/frame/ConsoleBase.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698